[gnome-software] Revert "trivial: Only allow unique IDs when using --details"
- From: Kalev Lember <klember src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software] Revert "trivial: Only allow unique IDs when using --details"
- Date: Mon, 16 Jan 2017 13:37:22 +0000 (UTC)
commit 5fb636a6007302befae385b58acc0e5d01684576
Author: Kalev Lember <klember redhat com>
Date: Mon Jan 16 14:35:43 2017 +0100
Revert "trivial: Only allow unique IDs when using --details"
gnome-shell uses the app ID to show details about apps. Activities,
right click on a launcher, "Show Details".
This reverts commit 72bdefb1751f935a2713e67605fd4cedbdb9c440.
src/gs-application.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/src/gs-application.c b/src/gs-application.c
index e07d08b..10bfe34 100644
--- a/src/gs-application.c
+++ b/src/gs-application.c
@@ -541,11 +541,12 @@ details_activated (GSimpleAction *action,
gs_shell_show_search_result (app->shell, id, search);
else {
g_autoptr (GsApp) a = NULL;
- if (!as_utils_unique_id_valid (id)) {
- g_warning ("Need to use a valid unique-id: %s", id);
- return;
- }
- a = gs_plugin_loader_app_create (app->plugin_loader, id);
+
+ if (as_utils_unique_id_valid (id))
+ a = gs_plugin_loader_app_create (app->plugin_loader, id);
+ else
+ a = gs_app_new (id);
+
gs_shell_show_app (app->shell, a);
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]