[gtk+] widget: Warn if children are left in finalize()



commit 08d644c4a53bf6068db1a10a217965ef9d749b83
Author: Timm Bäder <mail baedert org>
Date:   Wed Dec 7 14:05:34 2016 +0100

    widget: Warn if children are left in finalize()

 gtk/gtkwidget.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)
---
diff --git a/gtk/gtkwidget.c b/gtk/gtkwidget.c
index c644ac0..bbf5f3c 100644
--- a/gtk/gtkwidget.c
+++ b/gtk/gtkwidget.c
@@ -10615,6 +10615,19 @@ gtk_widget_finalize (GObject *object)
   g_list_free_full (priv->event_controllers, g_free);
   priv->event_controllers = NULL;
 
+  if (_gtk_widget_get_first_child (widget) != NULL)
+    {
+      GtkWidget *child;
+      g_warning ("Finalizing %s %p, but it still has children left:",
+                 gtk_widget_get_name (widget), widget);
+      for (child = _gtk_widget_get_first_child (widget);
+           child != NULL;
+           child = _gtk_widget_get_next_sibling (child))
+        {
+          g_warning ("   - %s %p", gtk_widget_get_name (child), child);
+        }
+    }
+
   if (g_object_is_floating (object))
     g_warning ("A floating object was finalized. This means that someone\n"
                "called g_object_unref() on an object that had only a floating\n"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]