[gnome-online-accounts] kerberos: Don't leak the return_key in sign_in_identity_sync



commit 6c4bb3072c0de3a6c48284c9178d184b9c9a0b28
Author: Debarshi Ray <debarshir gnome org>
Date:   Thu Jan 5 18:25:33 2017 +0100

    kerberos: Don't leak the return_key in sign_in_identity_sync
    
    https://bugzilla.gnome.org/show_bug.cgi?id=765121

 src/goabackend/goakerberosprovider.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/src/goabackend/goakerberosprovider.c b/src/goabackend/goakerberosprovider.c
index 9f36d05..c4654a3 100644
--- a/src/goabackend/goakerberosprovider.c
+++ b/src/goabackend/goakerberosprovider.c
@@ -1569,7 +1569,7 @@ sign_in_identity_sync (GoaKerberosProvider  *self,
 {
   GcrSecretExchange  *secret_exchange;
   char               *secret_key;
-  char               *return_key;
+  char               *return_key = NULL;
   char               *concealed_secret;
   char               *identity_object_path = NULL;
   gboolean            keys_exchanged;
@@ -1623,6 +1623,7 @@ sign_in_identity_sync (GoaKerberosProvider  *self,
   g_mutex_unlock (&identity_manager_mutex);
 
  out:
+  g_free (return_key);
   g_object_unref (secret_exchange);
   return identity_object_path;
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]