[epiphany] web-extension: Never automatically save password
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany] web-extension: Never automatically save password
- Date: Wed, 4 Jan 2017 17:01:56 +0000 (UTC)
commit 9525654e9c17a739eb23160a14cb7559247fd83b
Author: Michael Catanzaro <mcatanzaro gnome org>
Date: Wed Jan 4 10:54:57 2017 -0600
web-extension: Never automatically save password
This codepath can only be reached if you manually edit your permissions
file, since it's not exposed in the UI, but it was a bad idea. We should
never automatically save passwords because typing the password wrong
once would automatically delete your saved passwords.
https://bugzilla.gnome.org/show_bug.cgi?id=771073
embed/web-extension/ephy-web-extension.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
---
diff --git a/embed/web-extension/ephy-web-extension.c b/embed/web-extension/ephy-web-extension.c
index ffffcf9..cab7956 100644
--- a/embed/web-extension/ephy-web-extension.c
+++ b/embed/web-extension/ephy-web-extension.c
@@ -405,9 +405,6 @@ should_store_cb (const char *username,
g_free (username_field_value);
- } else if (permission == EPHY_HOST_PERMISSION_ALLOW) {
- LOG ("No result on query; storing.");
- store_password (form_auth);
} else {
LOG ("No result on query; asking whether we should store.");
request_decision_on_storing (g_object_ref (form_auth));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]