[gnome-online-accounts] Use CRITICALs, not WARNINGs, for programmer errors

[Debarshi Ray <debarshir src gnome org>]

commit 975b304cab6d747a89b1fb461ce5ed39dfe3ac85
Author: Debarshi Ray <debarshir gnome org>
Date:   Wed Jan 4 16:52:14 2017 +0100

    Use CRITICALs, not WARNINGs, for programmer errors
    
    Programmer errors indicate a mistake in the code and should always be
    treated as a bug. These are different from unexpected run-time errors,
    which can be caused by a broken system or a bunch of other external
    factors.

 src/goabackend/goakerberosprovider.c  |    2 +-
 src/goabackend/goaprovider.c          |    4 ++--
 src/goabackend/goatelepathyprovider.c |    2 +-
 src/goabackend/goatpaccountlinker.c   |    2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/src/goabackend/goakerberosprovider.c b/src/goabackend/goakerberosprovider.c
index 99eb5fb..9f36d05 100644
--- a/src/goabackend/goakerberosprovider.c
+++ b/src/goabackend/goakerberosprovider.c
@@ -1510,7 +1510,7 @@ remove_account_finish (GoaProvider   *provider,
   g_return_val_if_fail (g_task_is_valid (res, self), FALSE);
   task = G_TASK (res);
 
-  g_warn_if_fail (g_task_get_source_tag (task) == remove_account);
+  g_return_val_if_fail (g_task_get_source_tag (task) == remove_account, FALSE);
 
   return g_task_propagate_boolean (task, error);
 }
diff --git a/src/goabackend/goaprovider.c b/src/goabackend/goaprovider.c
index bae7343..4f13c36 100644
--- a/src/goabackend/goaprovider.c
+++ b/src/goabackend/goaprovider.c
@@ -786,7 +786,7 @@ goa_provider_ensure_credentials_finish (GoaProvider         *self,
   g_return_val_if_fail (g_task_is_valid (res, self), FALSE);
   task = G_TASK (res);
 
-  g_warn_if_fail (g_task_get_source_tag (task) == goa_provider_ensure_credentials);
+  g_return_val_if_fail (g_task_get_source_tag (task) == goa_provider_ensure_credentials, FALSE);
 
   /* Workaround for bgo#764163 */
   had_error = g_task_had_error (task);
@@ -1379,7 +1379,7 @@ goa_provider_remove_account_finish_real (GoaProvider   *self,
   g_return_val_if_fail (g_task_is_valid (res, self), FALSE);
   task = G_TASK (res);
 
-  g_warn_if_fail (g_task_get_source_tag (task) == goa_provider_remove_account_real);
+  g_return_val_if_fail (g_task_get_source_tag (task) == goa_provider_remove_account_real, FALSE);
 
   return g_task_propagate_boolean (task, error);
 }
diff --git a/src/goabackend/goatelepathyprovider.c b/src/goabackend/goatelepathyprovider.c
index ec4c069..847bf29 100644
--- a/src/goabackend/goatelepathyprovider.c
+++ b/src/goabackend/goatelepathyprovider.c
@@ -819,7 +819,7 @@ remove_account_finish (GoaProvider   *provider,
   g_return_val_if_fail (g_task_is_valid (res, self), FALSE);
   task = G_TASK (res);
 
-  g_warn_if_fail (g_task_get_source_tag (task) == remove_account);
+  g_return_val_if_fail (g_task_get_source_tag (task) == remove_account, FALSE);
 
   return g_task_propagate_boolean (task, error);
 }
diff --git a/src/goabackend/goatpaccountlinker.c b/src/goabackend/goatpaccountlinker.c
index 72ce9c5..6c2f459 100644
--- a/src/goabackend/goatpaccountlinker.c
+++ b/src/goabackend/goatpaccountlinker.c
@@ -663,7 +663,7 @@ goa_tp_account_linker_remove_tp_account_finish (GoaTpAccountLinker  *self,
   g_return_val_if_fail (g_task_is_valid (res, self), FALSE);
   task = G_TASK (res);
 
-  g_warn_if_fail (g_task_get_source_tag (task) == goa_tp_account_linker_remove_tp_account);
+  g_return_val_if_fail (g_task_get_source_tag (task) == goa_tp_account_linker_remove_tp_account, FALSE);
 
   return g_task_propagate_boolean (task, error);
 }