[network-manager-applet: 5/6] libnma: fix WirelessSecurity refcounting
- From: Beniamino Galvani <bgalvani src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [network-manager-applet: 5/6] libnma: fix WirelessSecurity refcounting
- Date: Tue, 3 Jan 2017 14:53:59 +0000 (UTC)
commit a1c9135595881b53a8d417e97a845ced7f21f748
Author: Beniamino Galvani <bgalvani redhat com>
Date: Thu Dec 22 18:26:12 2016 +0100
libnma: fix WirelessSecurity refcounting
gtk_tree_model_get() copies the returned boxed value, i.e. it calls
wireless_security_ref() and thus the element must be unreferenced
afterwards.
src/libnma/nma-wifi-dialog.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/src/libnma/nma-wifi-dialog.c b/src/libnma/nma-wifi-dialog.c
index ca989fc..a7098ee 100644
--- a/src/libnma/nma-wifi-dialog.c
+++ b/src/libnma/nma-wifi-dialog.c
@@ -269,6 +269,9 @@ stuff_changed_cb (WirelessSecurity *sec, gpointer user_data)
if (gtk_combo_box_get_active_iter (GTK_COMBO_BOX (priv->sec_combo), &iter))
gtk_tree_model_get (model, &iter, S_SEC_COLUMN, &sel_sec, -1);
+ if (sel_sec)
+ wireless_security_unref (sel_sec);
+
if (sel_sec != sec)
return;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]