[orca] Restore broken-text recovery attempts for words within editable Gecko content
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Restore broken-text recovery attempts for words within editable Gecko content
- Date: Tue, 3 Jan 2017 11:23:42 +0000 (UTC)
commit 8f39998948312bb292ec9ebafa83810c3a9d1867
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Tue Jan 3 06:19:19 2017 -0500
Restore broken-text recovery attempts for words within editable Gecko content
This aspect of Gecko's implementation seems more broken than lines and chars.
.../scripts/toolkits/Gecko/script_utilities.py | 4 ++--
src/orca/scripts/web/script_utilities.py | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/src/orca/scripts/toolkits/Gecko/script_utilities.py
b/src/orca/scripts/toolkits/Gecko/script_utilities.py
index a189037..778b83f 100644
--- a/src/orca/scripts/toolkits/Gecko/script_utilities.py
+++ b/src/orca/scripts/toolkits/Gecko/script_utilities.py
@@ -42,9 +42,9 @@ class Utilities(web.Utilities):
def __init__(self, script):
super().__init__(script)
- def _attemptBrokenTextRecovery(self, obj):
+ def _attemptBrokenTextRecovery(self, obj, **args):
if self.isContentEditableWithEmbeddedObjects(obj):
- return False
+ return args.get('boundary') == pyatspi.TEXT_BOUNDARY_WORD_START
return True
diff --git a/src/orca/scripts/web/script_utilities.py b/src/orca/scripts/web/script_utilities.py
index cbfa288..eab223d 100644
--- a/src/orca/scripts/web/script_utilities.py
+++ b/src/orca/scripts/web/script_utilities.py
@@ -860,7 +860,7 @@ class Utilities(script_utilities.Utilities):
return string, rangeStart, rangeEnd
- def _attemptBrokenTextRecovery(self, obj):
+ def _attemptBrokenTextRecovery(self, obj, **args):
return False
def _getTextAtOffset(self, obj, offset, boundary):
@@ -910,7 +910,7 @@ class Utilities(script_utilities.Utilities):
string, start, end = text.getTextAtOffset(offset, boundary)
# The above should be all that we need to do, but....
- if not self._attemptBrokenTextRecovery(obj):
+ if not self._attemptBrokenTextRecovery(obj, boundary=boundary):
s = string.replace(self.EMBEDDED_OBJECT_CHARACTER, "[OBJ]").replace("\n", "\\n")
msg = "WEB: Results for text at offset %i for %s using %s:\n" \
" String: '%s', Start: %i, End: %i.\n" \
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]