[gnome-builder] sourceview: Cleanup sort()



commit 2f7821fb65f070864e71d27f94d788117abad6ab
Author: Garrett Regier <garrettregier gmail com>
Date:   Tue Sep 13 09:44:39 2016 -0700

    sourceview: Cleanup sort()
    
    gtk_source_buffer_sort_lines() does all of this for us!
    
    https://bugzilla.gnome.org/show_bug.cgi?id=771367

 libide/sourceview/ide-source-view.c |   17 -----------------
 1 files changed, 0 insertions(+), 17 deletions(-)
---
diff --git a/libide/sourceview/ide-source-view.c b/libide/sourceview/ide-source-view.c
index 9087f91..e1b041e 100644
--- a/libide/sourceview/ide-source-view.c
+++ b/libide/sourceview/ide-source-view.c
@@ -4488,11 +4488,8 @@ ide_source_view_real_sort (IdeSourceView *self,
 {
   GtkTextView *text_view = (GtkTextView *)self;
   GtkTextBuffer *buffer;
-  GtkTextMark *insert;
   GtkTextIter begin;
   GtkTextIter end;
-  GtkTextIter cursor;
-  guint cursor_offset;
   GtkSourceSortFlags sort_flags = GTK_SOURCE_SORT_FLAGS_NONE;
 
   g_assert (GTK_TEXT_VIEW (self));
@@ -4504,31 +4501,17 @@ ide_source_view_real_sort (IdeSourceView *self,
   if (gtk_text_iter_equal (&begin, &end))
     gtk_text_buffer_get_bounds (buffer, &begin, &end);
 
-  insert = gtk_text_buffer_get_insert (buffer);
-  gtk_text_buffer_get_iter_at_mark (buffer, &cursor, insert);
-  cursor_offset = gtk_text_iter_get_offset (&cursor);
-
-  gtk_text_iter_order (&begin, &end);
-  if (gtk_text_iter_starts_line (&end))
-    gtk_text_iter_backward_char (&end);
-
   if (!ignore_case)
     sort_flags |= GTK_SOURCE_SORT_FLAGS_CASE_SENSITIVE;
 
   if (reverse)
     sort_flags |= GTK_SOURCE_SORT_FLAGS_REVERSE_ORDER;
 
-  gtk_text_buffer_begin_user_action (buffer);
-
   gtk_source_buffer_sort_lines (GTK_SOURCE_BUFFER (buffer),
                                 &begin,
                                 &end,
                                 sort_flags,
                                 0);
-  gtk_text_buffer_get_iter_at_offset (buffer, &begin, cursor_offset);
-  gtk_text_buffer_select_range (buffer, &begin, &begin);
-
-  gtk_text_buffer_end_user_action (buffer);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]