[metacity] don't add override-redirect windows to workspaces

[Alberts Muktupāvels <muktupavels src gnome org>]

commit 2e2c969f217fe366593772644a7e523d4552721c
Author: Owen W. Taylor <otaylor fishsoup net>
Date:   Mon Jun 15 18:02:32 2009 -0400

    don't add override-redirect windows to workspaces
    
    Normally a window that is "on all workspaces", is also on a particular
    workspace (to deal with being unstuck.) This is pointless for
    override-redirect windows.
    
    http://bugzilla.gnome.org/show_bug.cgi?id=582639

 src/core/window.c |   61 ++++++++++++++++++++++++++++------------------------
 1 files changed, 33 insertions(+), 28 deletions(-)
---
diff --git a/src/core/window.c b/src/core/window.c
index d153abe..3873da3 100644
--- a/src/core/window.c
+++ b/src/core/window.c
@@ -679,44 +679,49 @@ meta_window_new_with_attrs (MetaDisplay       *display,
         }
     }
 
-  if (window->workspace == NULL &&
-      window->xtransient_for != None)
+  /* override-redirect windows are subtly different from other windows
+   * with window->on_all_workspaces == TRUE. Other windows are part of
+   * some workspace (so they can return to that if the flag is turned off),
+   * but appear on other workspaces. override-redirect windows are part
+   * of no workspace.
+   */
+  if (!window->override_redirect)
     {
-      /* Try putting dialog on parent's workspace */
-      MetaWindow *parent;
+      if (window->workspace == NULL &&
+          window->xtransient_for != None)
+        {
+          /* Try putting dialog on parent's workspace */
+          MetaWindow *parent;
 
-      parent = meta_display_lookup_x_window (window->display,
-                                             window->xtransient_for);
+          parent = meta_display_lookup_x_window (window->display,
+                                                 window->xtransient_for);
 
-      if (parent && parent->workspace)
-        {
-          meta_topic (META_DEBUG_PLACEMENT,
-                      "Putting window %s on same workspace as parent %s\n",
-                      window->desc, parent->desc);
+          if (parent && parent->workspace)
+            {
+              meta_topic (META_DEBUG_PLACEMENT,
+                          "Putting window %s on same workspace as parent %s\n",
+                          window->desc, parent->desc);
 
-          if (parent->on_all_workspaces)
-            window->on_all_workspaces = TRUE;
+              if (parent->on_all_workspaces)
+                window->on_all_workspaces = TRUE;
 
-         /* this will implicitly add to the appropriate MRU lists
-          */
-          meta_workspace_add_window (parent->workspace, window);
+              /* this will implicitly add to the appropriate MRU lists */
+              meta_workspace_add_window (parent->workspace, window);
+            }
         }
-    }
 
-  if (window->workspace == NULL)
-    {
-      meta_topic (META_DEBUG_PLACEMENT,
-                  "Putting window %s on active workspace\n",
-                  window->desc);
+      if (window->workspace == NULL)
+        {
+          meta_topic (META_DEBUG_PLACEMENT,
+                      "Putting window %s on active workspace\n",
+                      window->desc);
 
-      space = window->screen->active_workspace;
+          space = window->screen->active_workspace;
 
-      meta_workspace_add_window (space, window);
-    }
+          meta_workspace_add_window (space, window);
+        }
 
-  /* for the various on_all_workspaces = TRUE possible above */
-  if (!window->override_redirect)
-    {
+      /* for the various on_all_workspaces = TRUE possible above */
       meta_window_set_current_workspace_hint (window);
 
       meta_window_update_struts (window);