[gnome-todo] todo-txt: remove unrelated code for GDir
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-todo] todo-txt: remove unrelated code for GDir
- Date: Wed, 22 Feb 2017 12:09:19 +0000 (UTC)
commit f975f2c95758a110f557b0315cdedc6869537e24
Author: Rohit Kaushik <kaushikrohit325 gmail com>
Date: Thu Feb 16 18:30:30 2017 +0530
todo-txt: remove unrelated code for GDir
This patch removes the unneccessary code for GDir which is not being
used now.
https://bugzilla.gnome.org/show_bug.cgi?id=778757
plugins/todo-txt/gtd-plugin-todo-txt.c | 52 ++++++++++----------------------
1 files changed, 16 insertions(+), 36 deletions(-)
---
diff --git a/plugins/todo-txt/gtd-plugin-todo-txt.c b/plugins/todo-txt/gtd-plugin-todo-txt.c
index 2e1eefe..ddbccf0 100644
--- a/plugins/todo-txt/gtd-plugin-todo-txt.c
+++ b/plugins/todo-txt/gtd-plugin-todo-txt.c
@@ -114,62 +114,42 @@ gtd_plugin_todo_txt_load_source_monitor (GtdPluginTodoTxt *self)
static gboolean
gtd_plugin_todo_txt_set_default_source (GtdPluginTodoTxt *self)
{
- GError *dir_open_error;
- GDir *default_dir = NULL;
gchar *default_file;
+ GError *error;
- dir_open_error = NULL;
default_file = g_strconcat (g_get_user_special_dir (G_USER_DIRECTORY_DOCUMENTS), "todo.txt", NULL);
+ error = NULL;
- if (dir_open_error)
+ self->source = g_filename_to_uri (default_file, NULL, &error);
+ self->source_file = g_file_new_for_uri (default_file);
+
+ if (error)
{
gtd_manager_emit_error_message (gtd_manager_get_default (),
- _("Error while opening the default Todo.txt directory"),
- dir_open_error->message);
+ _("Error while converting the default Todo.txt path to an URI"),
+ error->message);
- g_clear_error (&dir_open_error);
+ g_clear_error (&error);
return FALSE;
}
- else
- {
- GError *error;
- error = NULL;
-
- self->source = g_filename_to_uri (default_file, NULL, &error);
- self->source_file = g_file_new_for_uri (default_file);
+ if (!g_file_query_exists (self->source_file, NULL))
+ {
+ g_file_create (self->source_file,
+ G_FILE_CREATE_NONE,
+ NULL,
+ &error);
if (error)
{
gtd_manager_emit_error_message (gtd_manager_get_default (),
- _("Error while converting the default Todo.txt path to an URI"),
+ _("Cannot create Todo.txt file"),
error->message);
g_clear_error (&error);
return FALSE;
}
-
- if (!g_file_query_exists (self->source_file, NULL))
- {
- g_file_create (self->source_file,
- G_FILE_CREATE_NONE,
- NULL,
- &error);
-
- if (error)
- {
- gtd_manager_emit_error_message (gtd_manager_get_default (),
- _("Cannot create todo.txt file"),
- error->message);
-
- g_clear_error (&error);
- return FALSE;
- }
- }
-
- g_dir_close (default_dir);
}
-
return TRUE;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]