[gnome-builder] preferences: move sdk page registration to builtins



commit fa9c5660a7cf71a28c70de90edef519d174243b4
Author: Christian Hergert <chergert redhat com>
Date:   Sat Feb 18 12:40:36 2017 -0800

    preferences: move sdk page registration to builtins
    
    Lots of plugins may want to add things to the SDK management page, so go
    ahead and register this from our builtins.

 libide/preferences/ide-preferences-builtin.c |    8 ++++++++
 plugins/rustup/rustup_plugin/__init__.py     |    1 -
 2 files changed, 8 insertions(+), 1 deletions(-)
---
diff --git a/libide/preferences/ide-preferences-builtin.c b/libide/preferences/ide-preferences-builtin.c
index f6b0c8a..f9e2333 100644
--- a/libide/preferences/ide-preferences-builtin.c
+++ b/libide/preferences/ide-preferences-builtin.c
@@ -523,6 +523,13 @@ ide_preferences_builtin_register_vcs (IdePreferences *preferences)
   g_clear_object (&extensions);
 }
 
+static void
+ide_preferences_builtin_register_sdks (IdePreferences *preferences)
+{
+  /* only the page goes here, plugins will fill in the details */
+  ide_preferences_add_page (preferences, "sdk", _("SDKs"), 550);
+}
+
 void
 _ide_preferences_builtin_register (IdePreferences *preferences)
 {
@@ -536,4 +543,5 @@ _ide_preferences_builtin_register (IdePreferences *preferences)
   ide_preferences_builtin_register_build (preferences);
   ide_preferences_builtin_register_projects (preferences);
   ide_preferences_builtin_register_vcs (preferences);
+  ide_preferences_builtin_register_sdks (preferences);
 }
diff --git a/plugins/rustup/rustup_plugin/__init__.py b/plugins/rustup/rustup_plugin/__init__.py
index 038bb0b..269a939 100644
--- a/plugins/rustup/rustup_plugin/__init__.py
+++ b/plugins/rustup/rustup_plugin/__init__.py
@@ -420,7 +420,6 @@ class RustupPreferencesAddin(GObject.Object, Ide.PreferencesAddin):
        PreferencesAddin to display the installed rustup version and to change the rustup installation
     """
     def do_load(self, preferences):
-        preferences.add_page('sdk', _('SDKs'), 550)
         preferences.add_list_group('sdk', 'rustup', _('Rustup'), Gtk.SelectionMode.NONE, 100)
         preferences.add_group('sdk', 'rustup_toolchains_edit', _('Rustup Toolchains'), 100)
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]