[gnome-photos] item-manager: Remove the pointers for the object method signal handlers



commit baccc30b80abecf7e336812866d10ec2c300c8ab
Author: Debarshi Ray <debarshir gnome org>
Date:   Thu Feb 16 08:15:05 2017 +0100

    item-manager: Remove the pointers for the object method signal handlers
    
    This is a final class, so there wasn't going to be any sub-class that
    would want to override the default signal handler. We might still want
    a default handler for PhotosItemManager itself, but we can achieve the
    same effect with a simple private function. It is a small price to pay
    for being able to use G_DECLARE_FINAL_TYPE.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=763712

 src/photos-item-manager.c |   26 ++++++--------------------
 1 files changed, 6 insertions(+), 20 deletions(-)
---
diff --git a/src/photos-item-manager.c b/src/photos-item-manager.c
index cd2b88b..1bcab31 100644
--- a/src/photos-item-manager.c
+++ b/src/photos-item-manager.c
@@ -68,14 +68,6 @@ struct _PhotosItemManager
 struct _PhotosItemManagerClass
 {
   PhotosBaseManagerClass parent_class;
-
-  /* signals */
-  void (*active_collection_changed) (PhotosItemManager *self, PhotosBaseItem *collection);
-  void (*can_fullscreen_changed)    (PhotosItemManager *self);
-  void (*fullscreen_changed)        (PhotosItemManager *self, gboolean fullscreen);
-  void (*load_finished)             (PhotosItemManager *self, PhotosBaseItem *item, GeglNode *node);
-  void (*load_started)              (PhotosItemManager *self, PhotosBaseItem *item, GCancellable 
*cancellable);
-  void (*window_mode_changed)       (PhotosItemManager *self, PhotosWindowMode mode, PhotosWindowMode 
old_mode);
 };
 
 enum
@@ -905,8 +897,7 @@ photos_item_manager_class_init (PhotosItemManagerClass *class)
   signals[ACTIVE_COLLECTION_CHANGED] = g_signal_new ("active-collection-changed",
                                                      G_TYPE_FROM_CLASS (class),
                                                      G_SIGNAL_RUN_LAST,
-                                                     G_STRUCT_OFFSET (PhotosItemManagerClass,
-                                                                      active_collection_changed),
+                                                     0,
                                                      NULL, /*accumulator */
                                                      NULL, /*accu_data */
                                                      g_cclosure_marshal_VOID__OBJECT,
@@ -917,8 +908,7 @@ photos_item_manager_class_init (PhotosItemManagerClass *class)
   signals[CAN_FULLSCREEN_CHANGED] = g_signal_new ("can-fullscreen-changed",
                                                   G_TYPE_FROM_CLASS (class),
                                                   G_SIGNAL_RUN_LAST,
-                                                  G_STRUCT_OFFSET (PhotosItemManagerClass,
-                                                                   can_fullscreen_changed),
+                                                  0,
                                                   NULL, /*accumulator */
                                                   NULL, /*accu_data */
                                                   g_cclosure_marshal_VOID__VOID,
@@ -928,8 +918,7 @@ photos_item_manager_class_init (PhotosItemManagerClass *class)
   signals[FULLSCREEN_CHANGED] = g_signal_new ("fullscreen-changed",
                                               G_TYPE_FROM_CLASS (class),
                                               G_SIGNAL_RUN_LAST,
-                                              G_STRUCT_OFFSET (PhotosItemManagerClass,
-                                                               fullscreen_changed),
+                                              0,
                                               NULL, /*accumulator */
                                               NULL, /* accu_data */
                                               g_cclosure_marshal_VOID__BOOLEAN,
@@ -940,8 +929,7 @@ photos_item_manager_class_init (PhotosItemManagerClass *class)
   signals[LOAD_FINISHED] = g_signal_new ("load-finished",
                                          G_TYPE_FROM_CLASS (class),
                                          G_SIGNAL_RUN_LAST,
-                                         G_STRUCT_OFFSET (PhotosItemManagerClass,
-                                                          load_finished),
+                                         0,
                                          NULL, /*accumulator */
                                          NULL, /*accu_data */
                                          g_cclosure_marshal_generic,
@@ -953,8 +941,7 @@ photos_item_manager_class_init (PhotosItemManagerClass *class)
   signals[LOAD_STARTED] = g_signal_new ("load-started",
                                         G_TYPE_FROM_CLASS (class),
                                         G_SIGNAL_RUN_LAST,
-                                        G_STRUCT_OFFSET (PhotosItemManagerClass,
-                                                         load_started),
+                                        0,
                                         NULL, /*accumulator */
                                         NULL, /*accu_data */
                                         g_cclosure_marshal_VOID__OBJECT,
@@ -965,8 +952,7 @@ photos_item_manager_class_init (PhotosItemManagerClass *class)
   signals[WINDOW_MODE_CHANGED] = g_signal_new ("window-mode-changed",
                                                G_TYPE_FROM_CLASS (class),
                                                G_SIGNAL_RUN_LAST,
-                                               G_STRUCT_OFFSET (PhotosItemManagerClass,
-                                                                window_mode_changed),
+                                               0,
                                                NULL, /*accumulator */
                                                NULL, /*accu_data */
                                                _photos_marshal_VOID__ENUM_ENUM,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]