[gjs/wip/ptomato/mozjs38: 19/23] jsapi-util-root: Re-enable test



commit e81b2df1d78a5f60bc8981e7a92f2bbc60dd4059
Author: Philip Chimento <philip chimento gmail com>
Date:   Fri Feb 10 22:06:10 2017 -0800

    jsapi-util-root: Re-enable test
    
    SpiderMonkey 31's garbage collector was not smart enough to collect this
    object right after it was unrooted. But SpiderMonkey 38's is.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=777962

 test/gjs-test-rooting.cpp |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
---
diff --git a/test/gjs-test-rooting.cpp b/test/gjs-test-rooting.cpp
index a5f009e..240455f 100644
--- a/test/gjs-test-rooting.cpp
+++ b/test/gjs-test-rooting.cpp
@@ -202,10 +202,6 @@ static void
 test_maybe_owned_switch_to_unrooted_allows_collection(GjsRootingFixture *fx,
                                                       gconstpointer      unused)
 {
-    g_test_skip("mozjs31 garbage collector is not smart enough");
-    return;
-
-    /*
     auto obj = new GjsMaybeOwned<JSObject *>();
     obj->root(PARENT(fx)->cx, test_obj_new(fx));
 
@@ -214,7 +210,6 @@ test_maybe_owned_switch_to_unrooted_allows_collection(GjsRootingFixture *fx,
     g_assert_true(fx->finalized);
 
     delete obj;
-    */
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]