[orca] Don't present loading messages if document is neither showing nor visible



commit 3b1fc7348403d7795bc121ac6d391bdae4326820
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Fri Feb 10 04:06:40 2017 -0500

    Don't present loading messages if document is neither showing nor visible

 src/orca/scripts/web/script.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/orca/scripts/web/script.py b/src/orca/scripts/web/script.py
index a1027fa..930b9c6 100644
--- a/src/orca/scripts/web/script.py
+++ b/src/orca/scripts/web/script.py
@@ -1171,10 +1171,10 @@ class Script(default.Script):
             self.utilities.clearCaretContext()
 
         shouldPresent = self.utilities.isShowingOrVisible(event.source)
-        if not _settingsManager.getSetting('onlySpeakDisplayedText'):
+        if not _settingsManager.getSetting('onlySpeakDisplayedText') and shouldPresent:
             if event.detail1:
                 self.presentMessage(messages.PAGE_LOADING_START)
-            elif event.source.name and shouldPresent:
+            elif event.source.name:
                 msg = messages.PAGE_LOADING_END_NAMED % event.source.name
                 self.presentMessage(msg, resetStyles=False)
             else:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]