[network-manager-applet/th/build-non-recursive-make-bgo778400: 2/21] all: cleanup switch "fall through" comments



commit c2728bbbf86bfc3acfc4a77114abe665629594a1
Author: Thomas Haller <thaller redhat com>
Date:   Thu Feb 9 11:25:18 2017 +0100

    all: cleanup switch "fall through" comments
    
    Use common spelling, as these comments are considered by -Wimplicit-fallthrough.

 src/applet.c                      |    3 +--
 src/connection-editor/page-wifi.c |   30 +++++++++++++++---------------
 2 files changed, 16 insertions(+), 17 deletions(-)
---
diff --git a/src/applet.c b/src/applet.c
index fff0b65..31e2f44 100644
--- a/src/applet.c
+++ b/src/applet.c
@@ -2209,7 +2209,7 @@ foo_client_state_changed_cb (NMClient *client, GParamSpec *pspec, gpointer user_
                                            _("The network connection has been disconnected."),
                                            "nm-no-connection",
                                            PREF_DISABLE_DISCONNECTED_NOTIFICATIONS);
-               /* Fall through */
+               break;
        default:
                break;
        }
@@ -2555,7 +2555,6 @@ applet_get_device_icon_for_state (NMApplet *applet,
                        *out_tip = get_tip_for_device_state (device, state, connection);
                if (icon_name || *out_pixbuf)
                        return;
-               /* Fall through for common icons */
        }
 
 out:
diff --git a/src/connection-editor/page-wifi.c b/src/connection-editor/page-wifi.c
index fad89e7..fb648d1 100644
--- a/src/connection-editor/page-wifi.c
+++ b/src/connection-editor/page-wifi.c
@@ -216,16 +216,16 @@ band_value_changed_cb (GtkComboBox *box, gpointer user_data)
 
        priv->last_channel = 0;
        gtk_spin_button_set_value (priv->channel, 0);
- 
-       switch (gtk_combo_box_get_active (GTK_COMBO_BOX (box))) {
-       case 1: /* A */
-       case 2: /* B/G */
+
+       switch (gtk_combo_box_get_active (GTK_COMBO_BOX (box))) {
+       case 1: /* A */
+       case 2: /* B/G */
                sensitive = TRUE;
-               break;
-       default:
+               break;
+       default:
                sensitive = FALSE;
-               break;
-       }
+               break;
+       }
 
        gtk_widget_set_sensitive (GTK_WIDGET (priv->channel), sensitive);
 
@@ -244,22 +244,22 @@ mode_combo_changed_cb (GtkComboBox *combo,
        gboolean show_bssid = TRUE;
        gboolean hotspot = FALSE;
 
-       switch (gtk_combo_box_get_active (GTK_COMBO_BOX (combo))) {
+       switch (gtk_combo_box_get_active (GTK_COMBO_BOX (combo))) {
        case 1: /* hotspot */
                hotspot = TRUE;
-               /* fallthrough */
-       case 2: /* adhoc */
+               /* fall through */
+       case 2: /* adhoc */
                /* BSSID is random and is created by kernel for Ad-Hoc networks
                 * http://lxr.linux.no/linux+v3.7.6/net/mac80211/ibss.c#L685
                 * For AP-mode, the BSSID is the MAC address of the device.
                 */
                show_bssid = FALSE;
                show_freq = TRUE;
-               break;
-       default: /* infrastructure */
+               break;
+       default: /* infrastructure */
                show_freq = FALSE;
-               break;
-       }
+               break;
+       }
        nm_connection_editor_inter_page_set_value (parent->editor,
                                                   INTER_PAGE_CHANGE_WIFI_MODE,
                                                   GUINT_TO_POINTER (hotspot));


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]