[epiphany] web-view: Fix insecure password warning for insecure targets



commit 1ab1dd9a8533d80152e6d3882b2497cdf4b9d7fb
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Wed Feb 8 21:46:20 2017 -0600

    web-view: Fix insecure password warning for insecure targets
    
    Towards the end of development, I inverted the meaning of this boolean
    in a small refactoring, and in so doing accidentally broke this
    condition. The result was that the insecure password warning only worked
    if the target of the form was a secure page. And it just so happened
    that my primary test site was an insecure page where the login form used
    a secure target, which is how I didn't notice for two months.

 embed/ephy-web-view.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/embed/ephy-web-view.c b/embed/ephy-web-view.c
index 9b16686..befeea5 100644
--- a/embed/ephy-web-view.c
+++ b/embed/ephy-web-view.c
@@ -782,7 +782,7 @@ sensitive_form_focused_cb (EphyEmbedShell *shell,
     return;
   if (webkit_web_view_get_page_id (WEBKIT_WEB_VIEW (web_view)) != page_id)
     return;
-  if (insecure_action || ephy_security_level_is_secure (web_view->security_level))
+  if (!insecure_action && ephy_security_level_is_secure (web_view->security_level))
     return;
 
   /* Translators: Message appears when insecure password form is focused. */


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]