[gnome-builder/wip/chergert/pipeline: 35/48] command-queue: drop IdeBuildCommandQueue
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder/wip/chergert/pipeline: 35/48] command-queue: drop IdeBuildCommandQueue
- Date: Sat, 4 Feb 2017 00:11:45 +0000 (UTC)
commit 96053bd2b1dd1b7ddede3333c0067196153a21a6
Author: Christian Hergert <chergert redhat com>
Date: Fri Feb 3 13:51:14 2017 -0800
command-queue: drop IdeBuildCommandQueue
This should not be necessary going forward. But should it be, we can bring
it back.
libide/Makefile.am | 4 -
libide/buildsystem/ide-build-command-queue.c | 299 -------------------
libide/buildsystem/ide-build-command-queue.h | 53 ----
libide/buildsystem/ide-build-command.c | 403 --------------------------
libide/buildsystem/ide-build-command.h | 88 ------
libide/buildsystem/ide-configuration.c | 84 ------
libide/buildsystem/ide-configuration.h | 2 -
libide/ide.h | 2 -
8 files changed, 0 insertions(+), 935 deletions(-)
---
diff --git a/libide/Makefile.am b/libide/Makefile.am
index e2467c2..56d6895 100644
--- a/libide/Makefile.am
+++ b/libide/Makefile.am
@@ -31,8 +31,6 @@ libide_1_0_la_public_headers = \
buffers/ide-unsaved-file.h \
buffers/ide-unsaved-files.h \
buildsystem/ide-build-log.h \
- buildsystem/ide-build-command.h \
- buildsystem/ide-build-command-queue.h \
buildsystem/ide-build-manager.h \
buildsystem/ide-build-pipeline.h \
buildsystem/ide-build-pipeline-addin.h \
@@ -202,8 +200,6 @@ libide_1_0_la_public_sources = \
buffers/ide-buffer.c \
buffers/ide-unsaved-file.c \
buffers/ide-unsaved-files.c \
- buildsystem/ide-build-command.c \
- buildsystem/ide-build-command-queue.c \
buildsystem/ide-build-manager.c \
buildsystem/ide-build-pipeline.c \
buildsystem/ide-build-pipeline-addin.c \
diff --git a/libide/buildsystem/ide-configuration.c b/libide/buildsystem/ide-configuration.c
index 0bfc391..f836337 100644
--- a/libide/buildsystem/ide-configuration.c
+++ b/libide/buildsystem/ide-configuration.c
@@ -24,7 +24,6 @@
#include "ide-debug.h"
#include "ide-internal.h"
-#include "buildsystem/ide-build-command-queue.h"
#include "buildsystem/ide-configuration.h"
#include "buildsystem/ide-configuration-manager.h"
#include "buildsystem/ide-environment.h"
@@ -47,9 +46,6 @@ struct _IdeConfiguration
IdeEnvironment *environment;
- IdeBuildCommandQueue *prebuild;
- IdeBuildCommandQueue *postbuild;
-
GHashTable *internal;
gint parallelism;
@@ -265,8 +261,6 @@ ide_configuration_finalize (GObject *object)
IdeConfiguration *self = (IdeConfiguration *)object;
g_clear_object (&self->environment);
- g_clear_object (&self->prebuild);
- g_clear_object (&self->postbuild);
g_clear_pointer (&self->internal, g_hash_table_unref);
g_clear_pointer (&self->config_opts, g_free);
@@ -1033,12 +1027,6 @@ ide_configuration_snapshot (IdeConfiguration *self)
copy->environment = ide_environment_copy (self->environment);
- if (self->prebuild)
- copy->prebuild = ide_build_command_queue_copy (self->prebuild);
-
- if (self->postbuild)
- copy->postbuild = ide_build_command_queue_copy (self->postbuild);
-
g_hash_table_iter_init (&iter, self->internal);
while (g_hash_table_iter_next (&iter, (gpointer *)&key, (gpointer *)&value))
g_hash_table_insert (copy->internal, g_strdup (key), _value_copy (value));
@@ -1098,78 +1086,6 @@ ide_configuration_get_sequence (IdeConfiguration *self)
return self->sequence;
}
-/**
- * ide_configuration_get_prebuild:
- *
- * Gets a queue of commands to be run before the standard build process of
- * the configured build system. This can be useful for situations where the
- * user wants to setup some custom commands to prepare their environment.
- *
- * Constrast this with ide_configuration_get_postbuild() which gets commands
- * to be executed after the build system has completed.
- *
- * This function will always return a command queue. The command
- * queue may contain zero or more commands to be executed.
- *
- * Returns: (transfer full): An #IdeBuildCommandQueue.
- */
-IdeBuildCommandQueue *
-ide_configuration_get_prebuild (IdeConfiguration *self)
-{
- g_return_val_if_fail (IDE_IS_CONFIGURATION (self), NULL);
-
- if (self->prebuild != NULL)
- return g_object_ref (self->prebuild);
-
- return ide_build_command_queue_new ();
-}
-
-/**
- * ide_configuration_get_postbuild:
- *
- * Gets a queue of commands to be run after the standard build process of
- * the configured build system. This can be useful for situations where the
- * user wants to modify something after the build completes.
- *
- * Constrast this with ide_configuration_get_prebuild() which gets commands
- * to be executed before the build system has started.
- *
- * This function will always return a command queue. The command
- * queue may contain zero or more commands to be executed.
- *
- * Returns: (transfer full): An #IdeBuildCommandQueue.
- */
-IdeBuildCommandQueue *
-ide_configuration_get_postbuild (IdeConfiguration *self)
-{
- g_return_val_if_fail (IDE_IS_CONFIGURATION (self), NULL);
-
- if (self->postbuild != NULL)
- return g_object_ref (self->postbuild);
-
- return ide_build_command_queue_new ();
-}
-
-void
-_ide_configuration_set_prebuild (IdeConfiguration *self,
- IdeBuildCommandQueue *prebuild)
-{
- g_assert (IDE_IS_CONFIGURATION (self));
- g_assert (!prebuild || IDE_IS_BUILD_COMMAND_QUEUE (prebuild));
-
- g_set_object (&self->prebuild, prebuild);
-}
-
-void
-_ide_configuration_set_postbuild (IdeConfiguration *self,
- IdeBuildCommandQueue *postbuild)
-{
- g_assert (IDE_IS_CONFIGURATION (self));
- g_assert (!postbuild || IDE_IS_BUILD_COMMAND_QUEUE (postbuild));
-
- g_set_object (&self->postbuild, postbuild);
-}
-
static GValue *
ide_configuration_reset_internal_value (IdeConfiguration *self,
const gchar *key,
diff --git a/libide/buildsystem/ide-configuration.h b/libide/buildsystem/ide-configuration.h
index 10154e7..38552b8 100644
--- a/libide/buildsystem/ide-configuration.h
+++ b/libide/buildsystem/ide-configuration.h
@@ -76,8 +76,6 @@ IdeEnvironment *ide_configuration_get_environment (IdeConfiguration
IdeConfiguration *ide_configuration_duplicate (IdeConfiguration *self);
IdeConfiguration *ide_configuration_snapshot (IdeConfiguration *self);
guint ide_configuration_get_sequence (IdeConfiguration *self);
-IdeBuildCommandQueue *ide_configuration_get_prebuild (IdeConfiguration *self);
-IdeBuildCommandQueue *ide_configuration_get_postbuild (IdeConfiguration *self);
const gchar *ide_configuration_get_app_id (IdeConfiguration *self);
void ide_configuration_set_app_id (IdeConfiguration *self,
const gchar *app_id);
diff --git a/libide/ide.h b/libide/ide.h
index 00a2ce0..3908c54 100644
--- a/libide/ide.h
+++ b/libide/ide.h
@@ -35,8 +35,6 @@ G_BEGIN_DECLS
#include "buffers/ide-buffer.h"
#include "buffers/ide-unsaved-file.h"
#include "buffers/ide-unsaved-files.h"
-#include "buildsystem/ide-build-command.h"
-#include "buildsystem/ide-build-command-queue.h"
#include "buildsystem/ide-build-manager.h"
#include "buildsystem/ide-build-pipeline.h"
#include "buildsystem/ide-build-pipeline-addin.h"
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]