[glibmm/glibmm-2-50] Gio::Action: #include <glibmm/variant.h> in hg



commit 8b05dc9046e0e2a731f5674d64c63a6ecbdb3e6a
Author: Daniel Boles <dboles src gnome org>
Date:   Mon Jan 30 20:55:33 2017 +0000

    Gio::Action: #include <glibmm/variant.h> in hg
    
    Currently, it is included indirectly, via 3 other headers. This is
    brittle. Without that, users of action.h would have to manually include
    variant.h to use methods returning the forward-declared VariantBase,
    which isn’t very helpful. Plus, the header uses types like Variant<>
    templates and VariantContainerBase, which were never forward-declared.
    
    Including it directly makes the dependency more obvious and less brittle
    and spares us from having to write a bunch more forward-declarations.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=777953

 gio/src/action.hg |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
---
diff --git a/gio/src/action.hg b/gio/src/action.hg
index a7ce66e..f05d226 100644
--- a/gio/src/action.hg
+++ b/gio/src/action.hg
@@ -18,6 +18,7 @@
 _CONFIGINCLUDE(giommconfig.h)
 
 #include <glibmm/interface.h>
+#include <glibmm/variant.h>
 #include <glibmm/varianttype.h>
 #include <gio/gio.h>
 
@@ -29,13 +30,6 @@ _PINCLUDE(gio/gio.h)
 typedef struct _GActionInterface GActionInterface;
 #endif /* DOXYGEN_SHOULD_SKIP_THIS */
 
-namespace Glib
-{
-
-class VariantBase;
-
-}
-
 namespace Gio
 {
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]