[devhelp] BookManager: better enum names for the signals



commit ab0246e71ff3d9cc23b52401f50ae6b39abbb690
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Fri Dec 29 21:10:17 2017 +0100

    BookManager: better enum names for the signals
    
    With the prefix it eases code completion, among other benefits.

 src/dh-book-manager.c |   24 ++++++++++++------------
 1 files changed, 12 insertions(+), 12 deletions(-)
---
diff --git a/src/dh-book-manager.c b/src/dh-book-manager.c
index d92b53b..c87d20a 100644
--- a/src/dh-book-manager.c
+++ b/src/dh-book-manager.c
@@ -60,10 +60,10 @@ typedef struct {
 } DhBookManagerPrivate;
 
 enum {
-        BOOK_CREATED,
-        BOOK_DELETED,
-        BOOK_ENABLED,
-        BOOK_DISABLED,
+        SIGNAL_BOOK_CREATED,
+        SIGNAL_BOOK_DELETED,
+        SIGNAL_BOOK_ENABLED,
+        SIGNAL_BOOK_DISABLED,
         N_SIGNALS
 };
 
@@ -200,7 +200,7 @@ dh_book_manager_class_init (DhBookManagerClass *klass)
          * @book_manager: the #DhBookManager.
          * @book: the created #DhBook.
          */
-        signals[BOOK_CREATED] =
+        signals[SIGNAL_BOOK_CREATED] =
                 g_signal_new ("book-created",
                               G_TYPE_FROM_CLASS (klass),
                               G_SIGNAL_RUN_LAST,
@@ -215,7 +215,7 @@ dh_book_manager_class_init (DhBookManagerClass *klass)
          * @book_manager: the #DhBookManager.
          * @book: the deleted #DhBook.
          */
-        signals[BOOK_DELETED] =
+        signals[SIGNAL_BOOK_DELETED] =
                 g_signal_new ("book-deleted",
                               G_TYPE_FROM_CLASS (klass),
                               G_SIGNAL_RUN_LAST,
@@ -230,7 +230,7 @@ dh_book_manager_class_init (DhBookManagerClass *klass)
          * @book_manager: the #DhBookManager.
          * @book: the enabled #DhBook.
          */
-        signals[BOOK_ENABLED] =
+        signals[SIGNAL_BOOK_ENABLED] =
                 g_signal_new ("book-enabled",
                               G_TYPE_FROM_CLASS (klass),
                               G_SIGNAL_RUN_LAST,
@@ -245,7 +245,7 @@ dh_book_manager_class_init (DhBookManagerClass *klass)
          * @book_manager: the #DhBookManager.
          * @book: the disabled #DhBook.
          */
-        signals[BOOK_DISABLED] =
+        signals[SIGNAL_BOOK_DISABLED] =
                 g_signal_new ("book-disabled",
                               G_TYPE_FROM_CLASS (klass),
                               G_SIGNAL_RUN_LAST,
@@ -362,7 +362,7 @@ remove_book (DhBookManager *book_manager,
 
         if (node != NULL) {
                 g_signal_emit (book_manager,
-                               signals[BOOK_DELETED],
+                               signals[SIGNAL_BOOK_DELETED],
                                0,
                                book);
 
@@ -417,7 +417,7 @@ book_enabled_cb (DhBook        *book,
         store_books_disabled (book_manager);
 
         g_signal_emit (book_manager,
-                       signals[BOOK_ENABLED],
+                       signals[SIGNAL_BOOK_ENABLED],
                        0,
                        book);
 }
@@ -443,7 +443,7 @@ book_disabled_cb (DhBook        *book,
         store_books_disabled (book_manager);
 
         g_signal_emit (book_manager,
-                       signals[BOOK_DISABLED],
+                       signals[SIGNAL_BOOK_DISABLED],
                        0,
                        book);
 }
@@ -519,7 +519,7 @@ create_book_from_index_file (DhBookManager *book_manager,
                                  0);
 
         g_signal_emit (book_manager,
-                       signals[BOOK_CREATED],
+                       signals[SIGNAL_BOOK_CREATED],
                        0,
                        book);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]