[babl] babl: re-enable earlier bailing for big path errors



commit 370d22c25b4fe74ffcaa9aaaa0cfc764c7c47c27
Author: Øyvind Kolås <pippin gimp org>
Date:   Wed Dec 20 03:22:00 2017 +0100

    babl: re-enable earlier bailing for big path errors
    
    This is one way of dealing with 790658 - that in general is a good idea as
    well.

 babl/babl-fish-path.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/babl/babl-fish-path.c b/babl/babl-fish-path.c
index 6a1e194..4b087fc 100644
--- a/babl/babl-fish-path.c
+++ b/babl/babl-fish-path.c
@@ -210,7 +210,7 @@ get_conversion_path (PathContext *pc,
       double path_cost  = 0.0;
       double ref_cost   = 0.0;
       double path_error = 1.0;
-#if 0
+#if 1
       int    i;
       for (i = 0; i < babl_list_size (pc->current_path); i++)
         {
@@ -219,7 +219,8 @@ get_conversion_path (PathContext *pc,
 
       if (path_error - 1.0 <= legal_error )
                 /* check this before the more accurate measurement of error -
-                   to bail earlier */
+                   to bail earlier, this also leads to a stricter
+                   discarding of bad fast paths  */
 #endif
         {
           FishPathInstrumentation fpi;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]