[network-manager-applet] editor: streamline the editor sensitivity handling
- From: Lubomir Rintel <lkundrak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [network-manager-applet] editor: streamline the editor sensitivity handling
- Date: Tue, 19 Dec 2017 12:41:41 +0000 (UTC)
commit b3834d33c5d117653d627eca5eb947015535ad0b
Author: Lubomir Rintel <lkundrak v3 sk>
Date: Tue Dec 19 12:25:23 2017 +0100
editor: streamline the editor sensitivity handling
Get rid of an extra variable & nesting.
src/connection-editor/nm-connection-editor.c | 14 +++++---------
1 files changed, 5 insertions(+), 9 deletions(-)
---
diff --git a/src/connection-editor/nm-connection-editor.c b/src/connection-editor/nm-connection-editor.c
index e6f2ccf..9427718 100644
--- a/src/connection-editor/nm-connection-editor.c
+++ b/src/connection-editor/nm-connection-editor.c
@@ -147,7 +147,7 @@ static void
update_sensitivity (NMConnectionEditor *editor)
{
NMSettingConnection *s_con;
- gboolean actionable = FALSE, authorized = FALSE, sensitive = FALSE;
+ gboolean sensitive = FALSE;
GtkWidget *widget;
GSList *iter;
@@ -156,17 +156,13 @@ update_sensitivity (NMConnectionEditor *editor)
/* Can't modify read-only connections; can't modify anything before the
* editor is initialized either.
*/
- if ( !nm_setting_connection_get_read_only (s_con)
- && editor_is_initialized (editor)) {
- if (editor->can_modify) {
- actionable = ce_polkit_button_get_actionable (CE_POLKIT_BUTTON (editor->ok_button));
- authorized = ce_polkit_button_get_authorized (CE_POLKIT_BUTTON (editor->ok_button));
- }
-
+ if ( editor_is_initialized (editor)
+ && editor->can_modify
+ && !nm_setting_connection_get_read_only (s_con)) {
/* If the user cannot ever be authorized to change system connections,
* we desensitize the entire dialog.
*/
- sensitive = authorized;
+ sensitive = ce_polkit_button_get_authorized (CE_POLKIT_BUTTON (editor->ok_button));
}
/* Cancel button is always sensitive */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]