[gnome-continuous-yocto/gnomeostree-3.28-rocko: 7247/8267] mkelfimage: Make -fno-stack-protector effective



commit ba1a7556b9b190c540519080ffe215f23c037fc7
Author: Khem Raj <raj khem gmail com>
Date:   Wed Aug 16 14:10:53 2017 -0700

    mkelfimage: Make -fno-stack-protector effective
    
    mkelfimage uses different flags to compile as freestanding binary
    it does not pour CFLAGS into them during configure as a result
    -fno-stack-protector was never used. Which failed to build with
    compilers configured to build with ssp by default. It worked with
    gcc since we do not configure our toolchain to default to ssp
    
    Fixes errors e.g.
    | objdir/linux-i386/convert_params.o: In function `convert_params':
    | linux-i386/convert_params.c:(.text+0x9f4): undefined reference to `__stack_chk_fail'
    | objdir/linux-i386/convert_params.o: In function `compute_checksum':
    | linux-i386/convert_params.c:(.text+0xa71): undefined reference to `__stack_chk_fail'
    | objdir/linux-i386/convert_params.o: In function `printf':
    | linux-i386/convert_params.c:(.text+0xcc7): undefined reference to `__stack_chk_fail'
    | make: *** [linux-i386/Makefile:24: objdir/linux-i386/convert] Error 1
    
    (From OE-Core rev: f6ed82482838e34202721be8f40ca1cc340c325e)
    
    Signed-off-by: Khem Raj <raj khem gmail com>
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 meta/recipes-devtools/mkelfimage/mkelfimage_git.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb 
b/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb
index 2ad4b49..05a5a1a 100644
--- a/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb
+++ b/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb
@@ -23,11 +23,12 @@ CLEANBROKEN = "1"
 
 S = "${WORKDIR}/git/util/mkelfImage"
 
-CFLAGS += "-fno-stack-protector"
 CACHED_CONFIGUREVARS += "\
     HOST_CC='${BUILD_CC}' \
     HOST_CFLAGS='${BUILD_CFLAGS}' \
     HOST_CPPFLAGS='${BUILD_CPPFLAGS}' \
+    I386_CFLAGS='-fno-stack-protector' \
+    IA64_CFLAGS='-fno-stack-protector' \
 "
 EXTRA_OECONF_append_x86-64 = " --with-i386=${HOST_SYS}"
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]