[gnome-continuous-yocto/gnomeostree-3.28-rocko: 2328/8267] recipetool: create: avoid extra blank lines in output recipe



commit ce4ea7a730a7bec257218533b7c1fcb31134e25b
Author: Paul Eggleton <paul eggleton linux intel com>
Date:   Tue Sep 6 11:24:44 2016 +1200

    recipetool: create: avoid extra blank lines in output recipe
    
    If we output extra blank lines (because of some automated editing) then
    it makes the output recipe look a bit untidy. You could argue that we
    should simply have the editing code not do that, but sometimes we don't
    have enough context there for that to be practical. It's simple enough
    to just filter out the extra blank lines when writing the file, so just
    do it that way.
    
    (From OE-Core rev: cbebc9a2edf7d7a422ee5c71219e79e3b349de3b)
    
    Signed-off-by: Paul Eggleton <paul eggleton linux intel com>
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 scripts/lib/recipetool/create.py |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
---
diff --git a/scripts/lib/recipetool/create.py b/scripts/lib/recipetool/create.py
index 6ed4ad0..cd86747 100644
--- a/scripts/lib/recipetool/create.py
+++ b/scripts/lib/recipetool/create.py
@@ -714,7 +714,13 @@ def create_recipe(args):
         sys.stdout.write('\n'.join(outlines) + '\n')
     else:
         with open(outfile, 'w') as f:
-            f.write('\n'.join(outlines) + '\n')
+            lastline = None
+            for line in outlines:
+                if not lastline and not line:
+                    # Skip extra blank lines
+                    continue
+                f.write('%s\n' % line)
+                lastline = line
         logger.info('Recipe %s has been created; further editing may be required to make it fully 
functional' % outfile)
 
     if tempsrc:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]