[gnome-continuous-yocto/gnomeostree-3.28-rocko: 7517/8267] insane.bbclass: Warn if ${COREBASE}/LICENSE is used

[Emmanuele Bassi <ebassi src gnome org>]

commit 6e224e9c8e3850ced305b9cd971b093d8a588d5e
Author: Saul Wold <sgw linux intel com>
Date:   Fri Sep 1 14:53:25 2017 -0700

    insane.bbclass: Warn if ${COREBASE}/LICENSE is used
    
    The top level LICENSE file is not actually a license, it refers
    other licenses that are used by Bitbake and Meta-data. Relying
    on this file could cause problems for recipes when this file
    changes, which it is about to.
    
    (From OE-Core rev: a1948ab38c9cb7f0b16cce9dadc03ae6e2fe44ad)
    
    (From OE-Core rev: dd75644db2f662f0d88529a068bbfb599c9790a9)
    
    Signed-off-by: Saul Wold <sgw linux intel com>
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 meta/classes/insane.bbclass |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 3906ba7..aa304f1 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -589,7 +589,7 @@ python populate_lic_qa_checksum() {
         sane = package_qa_handle_error("license-checksum", pn + ": Recipe file fetches files and does not 
have license file information (LIC_FILES_CHKSUM)", d)
 
     srcdir = d.getVar('S')
-
+    corebase_licensefile = d.getVar('COREBASE') + "/LICENSE"
     for url in lic_files.split():
         try:
             (type, host, path, user, pswd, parm) = bb.fetch.decodeurl(url)
@@ -601,6 +601,9 @@ python populate_lic_qa_checksum() {
             package_qa_handle_error("license-checksum", pn + ": LIC_FILES_CHKSUM points to an invalid file: 
" + srclicfile, d)
             continue
 
+        if (srclicfile == corebase_licensefile):
+            bb.warn("${COREBASE}/LICENSE is not a valid license file, please use '${COMMON_LICENSE_DIR}/MIT' 
for a MIT License file in LIC_FILES_CHKSUM. This will become an error in the future")
+
         recipemd5 = parm.get('md5', '')
         beginline, endline = 0, 0
         if 'beginline' in parm: