[gnome-continuous-yocto/gnomeostree-3.28-rocko: 5656/8267] sstate.bbclass: check if mirror directory is writable



commit 42734220721e3aaa46642014319d91189e63ce9f
Author: Ed Bartosh <ed bartosh linux intel com>
Date:   Thu Apr 13 00:00:18 2017 +0300

    sstate.bbclass: check if mirror directory is writable
    
    Commit 51edde653707e7a3cd2186082458f01f32cd1996 makes a wrong assumption
    that SSTATE_MIRRORS have write permissions.
    
    A mirror is by definition outside of it's user control. In my use case
    it happens I does not have permissions to update the access time of the
    dereferenced symbolic-link file.
    
    Checked if file is writable before changing its atime.
    
    Thanks to Paulo Neves for the patch.
    
    [YOCTO #11307]
    
    (From OE-Core rev: b8f26c011d5ed888d85fef040bd821400d54c8fe)
    
    Signed-off-by: Ed Bartosh <ed bartosh linux intel com>
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 meta/classes/sstate.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
index bc0ec54..5b66c01 100644
--- a/meta/classes/sstate.bbclass
+++ b/meta/classes/sstate.bbclass
@@ -753,7 +753,7 @@ python sstate_sign_package () {
 sstate_unpack_package () {
        tar -xvzf ${SSTATE_PKG}
        # update .siginfo atime on local/NFS mirror
-       [ -h ${SSTATE_PKG}.siginfo ] && touch -a ${SSTATE_PKG}.siginfo
+       [ -w ${SSTATE_PKG}.siginfo ] && [ -h ${SSTATE_PKG}.siginfo ] && touch -a ${SSTATE_PKG}.siginfo
        # Use "! -w ||" to return true for read only files
        [ ! -w ${SSTATE_PKG} ] || touch --no-dereference ${SSTATE_PKG}
        [ ! -w ${SSTATE_PKG}.sig ] || [ ! -e ${SSTATE_PKG}.sig ] || touch --no-dereference ${SSTATE_PKG}.sig


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]