[gnome-continuous-yocto/gnomeostree-3.28-rocko: 4170/8267] package_deb: Improve failure debug output

[Emmanuele Bassi <ebassi src gnome org>]

commit 53a3c5877458678732e43ec92798f0b3f6f9bac6
Author: Richard Purdie <richard purdie linuxfoundation org>
Date:   Sat Jan 21 13:55:36 2017 +0000

    package_deb: Improve failure debug output
    
    Currently if the dpkg-deb command fails you see an error message like this:
    
    ERROR: nss-3.27.1-r0 do_package_write_deb: dpkg-deb execution failed
    ERROR: nss-3.27.1-r0 do_package_write_deb: Function failed: do_package_deb
    
    which is pretty much useless. If we use subprocess.check_output, we see a
    traceback and then:
    
    Exception: subprocess.CalledProcessError: Command '<cmd>' returned non-zero exit status 1
    
    Subprocess output:
    <output>
    
    which is much easier to debug from.
    
    (From OE-Core rev: 18160442869f56ee71538bc2dc60d7cb6c08c8a2)
    
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 meta/classes/package_deb.bbclass |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
---
diff --git a/meta/classes/package_deb.bbclass b/meta/classes/package_deb.bbclass
index 6ce008f..2a70b50 100644
--- a/meta/classes/package_deb.bbclass
+++ b/meta/classes/package_deb.bbclass
@@ -308,10 +308,7 @@ python do_package_deb () {
             conffiles.close()
 
         os.chdir(basedir)
-        ret = subprocess.call("PATH=\"%s\" dpkg-deb -b %s %s" % (localdata.getVar("PATH"), root, pkgoutdir), 
shell=True)
-        if ret != 0:
-            bb.utils.unlockfile(lf)
-            bb.fatal("dpkg-deb execution failed")
+        subprocess.check_output("PATH=\"%s\" dpkg-deb -b %s %s" % (localdata.getVar("PATH"), root, 
pkgoutdir), shell=True)
 
         cleanupcontrol(root)
         bb.utils.unlockfile(lf)