[gnome-continuous-yocto/gnomeostree-3.28-rocko: 3476/8267] insane: fix expanded-d test
- From: Emmanuele Bassi <ebassi src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-continuous-yocto/gnomeostree-3.28-rocko: 3476/8267] insane: fix expanded-d test
- Date: Sun, 17 Dec 2017 00:41:12 +0000 (UTC)
commit 56d3c77ebec22b65efbd9f11abb201af3102df64
Author: Ross Burton <ross burton intel com>
Date: Thu Nov 24 11:24:26 2016 +0000
insane: fix expanded-d test
This test should be looking for the expanded value of ${D} in the expanded value
of pkg_postinst and so on, but one of the getVar() calls was passing
expand=False so the test would never be true.
(From OE-Core rev: cc545044cba51317bee32e3bf674723e422e3a8a)
Signed-off-by: Ross Burton <ross burton intel com>
Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>
meta/classes/insane.bbclass | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index d51e73e..9f3065f 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -1000,9 +1000,8 @@ def package_qa_check_expanded_d(path,name,d,elf,messages):
for pak in packages:
# Go through all variables and check if expanded D is found, warn the user accordingly
for var in 'FILES','pkg_preinst', 'pkg_postinst', 'pkg_prerm', 'pkg_postrm':
- bbvar = d.getVar(var + "_" + pak, False)
+ bbvar = d.getVar(var + "_" + pak, True)
if bbvar:
- # Bitbake expands ${D} within bbvar during the previous step, so we check for its expanded
value
if expanded_d in bbvar:
if var == 'FILES':
package_qa_add_message(messages, "expanded-d", "FILES in %s recipe should not
contain the ${D} variable as it references the local build directory not the target filesystem, best solution
is to remove the ${D} reference" % pak)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]