[gnome-continuous-yocto/gnomeostree-3.28-rocko: 4472/8267] wic: direct: fix creation of work directory



commit 14652a42d81adf0340b580342a316a37996b0d37
Author: Ed Bartosh <ed bartosh linux intel com>
Date:   Thu Feb 2 15:32:58 2017 +0200

    wic: direct: fix creation of work directory
    
    It was a typo in current code: mktemp was used instead of
    mkdtemp to create work directory. This is fixed by using
    mkdtemp.
    
    Create work directory as a subdirectory of output directory
    to make sure both are on the same partition to make moving
    of result image faster.
    
    This also fixes possible disk space issues as mkdtemp uses
    TMPDIR, TEMP or TMP environment variables to get default value
    of its 'dir' parameter. Those variables are usually pointing
    to /tmp, which is not the best location to create huge images.
    
    (From OE-Core rev: e6579b4e007ce89000c46c09917fbd3c72f18a73)
    
    Signed-off-by: Ed Bartosh <ed bartosh linux intel com>
    Signed-off-by: Ross Burton <ross burton intel com>
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 scripts/lib/wic/plugins/imager/direct.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/scripts/lib/wic/plugins/imager/direct.py b/scripts/lib/wic/plugins/imager/direct.py
index 4637fbf..b38e876 100644
--- a/scripts/lib/wic/plugins/imager/direct.py
+++ b/scripts/lib/wic/plugins/imager/direct.py
@@ -122,7 +122,7 @@ class DirectImageCreator:
         """
         self.name = name
         self.outdir = outdir
-        self.workdir = tempfile.mktemp(prefix='wic')
+        self.workdir = tempfile.mkdtemp(dir=outdir, prefix='tmp.wic.')
         self.ks = ksobj
 
         self._image = None


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]