[gnome-continuous-yocto/gnomeostree-3.28-rocko: 2561/8267] bitbake: toaster: unlock BuildEnvirnoment when build is done



commit 7a3cccbd1aa4333df6ab46d87b4b1f39d1fe683d
Author: Ed Bartosh <ed bartosh linux intel com>
Date:   Fri Sep 16 17:22:35 2016 +0100

    bitbake: toaster: unlock BuildEnvirnoment when build is done
    
    There is no need to lock build environment before changing
    build status as this operation is very fast. However, there
    is a need to unlock it after changing build status.
    
    Explicitly unlocked BuildEnvironment after build reaches
    final status SUCCEEDED, FAILED or CANCELLED. This should
    allow runbuilds process to pickup next build faster.
    
    (Bitbake rev: faa88272d656640c039572c5c8f3e6c56535b6f7)
    
    Signed-off-by: Ed Bartosh <ed bartosh linux intel com>
    Signed-off-by: Michael Wood <michael g wood intel com>
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 bitbake/lib/bb/ui/buildinfohelper.py |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
---
diff --git a/bitbake/lib/bb/ui/buildinfohelper.py b/bitbake/lib/bb/ui/buildinfohelper.py
index c93ee94..2246960 100644
--- a/bitbake/lib/bb/ui/buildinfohelper.py
+++ b/bitbake/lib/bb/ui/buildinfohelper.py
@@ -1524,9 +1524,7 @@ class BuildInfoHelper(object):
             return
 
         br_id, be_id = self.brbe.split(":")
-        be = BuildEnvironment.objects.get(pk = be_id)
-        be.lock = BuildEnvironment.LOCK_LOCK
-        be.save()
+
         br = BuildRequest.objects.get(pk = br_id)
 
         # if we're 'done' because we got cancelled update the build outcome
@@ -1543,6 +1541,10 @@ class BuildInfoHelper(object):
         else:
             br.state = BuildRequest.REQ_FAILED
         br.save()
+
+        be = BuildEnvironment.objects.get(pk = be_id)
+        be.lock = BuildEnvironment.LOCK_FREE
+        be.save()
         signal_runbuilds()
 
     def store_log_error(self, text):


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]