[gnome-continuous-yocto/gnomeostree-3.28-rocko: 251/8267] bitbake: knotty: Ensure consolelog file handle is closed



commit 7d06ec193ee5f4c4910365981ccbfc717d87b573
Author: Richard Purdie <richard purdie linuxfoundation org>
Date:   Wed May 11 22:55:53 2016 +0100

    bitbake: knotty: Ensure consolelog file handle is closed
    
    If we don't close the console log file handle, python prints a warning
    about unclosed file handles upon exit which is annoying.
    
    (Bitbake rev: 624dd92952b2fc736fd86abe5f2390b87b3a7dd3)
    
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 bitbake/lib/bb/ui/knotty.py |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
---
diff --git a/bitbake/lib/bb/ui/knotty.py b/bitbake/lib/bb/ui/knotty.py
index 903d72b..85a71f4 100644
--- a/bitbake/lib/bb/ui/knotty.py
+++ b/bitbake/lib/bb/ui/knotty.py
@@ -278,6 +278,7 @@ def main(server, eventHandler, params, tf = TerminalFilter):
         server.terminateServer()
         return
 
+    consolelog = None
     if consolelogfile and not params.options.show_environment and not params.options.show_versions:
         bb.utils.mkdirhier(os.path.dirname(consolelogfile))
         conlogformat = bb.msg.BBLogFormatter(format_str)
@@ -591,4 +592,8 @@ def main(server, eventHandler, params, tf = TerminalFilter):
         if e.errno == errno.EPIPE:
             pass
 
+    if consolelog:
+        logger.removeHandler(consolelog)
+        consolelog.close()
+
     return return_value


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]