[gnome-continuous-yocto/gnomeostree-3.28-rocko: 170/8267] update-alternatives: Fix determinism issue



commit f49be7e7c9558de5a5aa3321bec3e92aa3bf5e8c
Author: Richard Purdie <richard purdie linuxfoundation org>
Date:   Mon May 9 14:12:16 2016 +0100

    update-alternatives: Fix determinism issue
    
    getVarFlags returns a dict and there is therefore no sort order. This
    means the order of the X_VARDEPS_X variables can change and hence the
    task checksums can change. This can lead to rebuilds of any parts of
    the system using update-alternatives and their dependees. This is a
    particular issue under python v3.
    
    Add in a sort to make the order of the variables deterministic.
    
    (From OE-Core rev: ecd1bfed5534f83b775a6c79092c04bd13c3af0a)
    
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 meta/classes/update-alternatives.bbclass |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/meta/classes/update-alternatives.bbclass b/meta/classes/update-alternatives.bbclass
index 70a8185..1fdd681 100644
--- a/meta/classes/update-alternatives.bbclass
+++ b/meta/classes/update-alternatives.bbclass
@@ -71,14 +71,14 @@ def gen_updatealternativesvardeps(d):
 
     # First compute them for non_pkg versions
     for v in vars:
-        for flag in (d.getVarFlags(v) or {}):
+        for flag in sorted((d.getVarFlags(v) or {}).keys()):
             if flag == "doc" or flag == "vardeps" or flag == "vardepsexp":
                 continue
             d.appendVar('%s_VARDEPS' % (v), ' %s:%s' % (flag, d.getVarFlag(v, flag, False)))
 
     for p in pkgs:
         for v in vars:
-            for flag in (d.getVarFlags("%s_%s" % (v,p)) or {}):
+            for flag in sorted((d.getVarFlags("%s_%s" % (v,p)) or {}).keys()):
                 if flag == "doc" or flag == "vardeps" or flag == "vardepsexp":
                     continue
                 d.appendVar('%s_VARDEPS_%s' % (v,p), ' %s:%s' % (flag, d.getVarFlag('%s_%s' % (v,p), flag, 
False)))


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]