[epiphany/wip/idn-display] uri-helpers: Implement Mozilla's IDN display algorithm
- From: Gabriel Ivașcu <gabrielivascu src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/wip/idn-display] uri-helpers: Implement Mozilla's IDN display algorithm
- Date: Sat, 16 Dec 2017 18:51:02 +0000 (UTC)
commit 2ff7d1038c8e8940b5eb1788b89024b2f0196cca
Author: Gabriel Ivascu <gabrielivascu gnome org>
Date: Sat Dec 16 20:49:24 2017 +0200
uri-helpers: Implement Mozilla's IDN display algorithm
https://wiki.mozilla.org/IDN_Display_Algorithm#Algorithm
lib/ephy-uri-helpers.c | 149 +++++++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 148 insertions(+), 1 deletions(-)
---
diff --git a/lib/ephy-uri-helpers.c b/lib/ephy-uri-helpers.c
index 7b00593..fc612dd 100644
--- a/lib/ephy-uri-helpers.c
+++ b/lib/ephy-uri-helpers.c
@@ -252,6 +252,150 @@ ephy_remove_tracking_from_uri (const char *uri_string)
return ret;
}
+static inline void
+script_table_update (GHashTable *table,
+ GUnicodeScript script)
+{
+ gpointer value;
+ gpointer new_value;
+
+ value = g_hash_table_lookup (table, GINT_TO_POINTER (script));
+ new_value = GINT_TO_POINTER (GPOINTER_TO_INT (value) + 1);
+ g_hash_table_replace (table, GINT_TO_POINTER (script), new_value);
+}
+
+static inline int
+script_table_get (GHashTable *table,
+ GUnicodeScript script)
+{
+ gpointer value;
+
+ value = g_hash_table_lookup (table, GINT_TO_POINTER (script));
+ return GPOINTER_TO_INT (value);
+}
+
+/*
+ * https://wiki.mozilla.org/IDN_Display_Algorithm#Algorithm
+ */
+static gboolean
+validate_label_for_display (const char *label)
+{
+ GHashTable *table;
+ GUnicodeScript script;
+ gunichar *unichars;
+ gunichar saved_zero_char = 0;
+ gboolean retval = FALSE;
+ long num;
+
+ g_assert (label);
+
+ if (!g_utf8_validate (label, -1, NULL))
+ return FALSE;
+
+ /* Use a hash table to count the occurrences of every script,
+ * except Common and Inherited. */
+ table = g_hash_table_new (g_direct_hash, g_direct_equal);
+ unichars = g_utf8_to_ucs4_fast (label, -1, &num);
+
+ for (gunichar *u = unichars; u && *u; u++) {
+ script = g_unichar_get_script (*u);
+
+ if (script != G_UNICODE_SCRIPT_COMMON && script != G_UNICODE_SCRIPT_INHERITED)
+ script_table_update (table, script);
+ else
+ num--;
+
+ /* Check for mixed numbering systems. */
+ if (g_unichar_isdigit (*u)) {
+ gunichar zero_char = *u - g_unichar_digit_value (*u);
+ if (saved_zero_char == 0)
+ saved_zero_char = zero_char;
+ else if (zero_char != saved_zero_char)
+ goto out;
+ }
+ }
+
+ /* Single script, allow. */
+ if (g_hash_table_size (table) < 2) {
+ retval = TRUE;
+ goto out;
+ }
+
+ /* Chinese scripts. */
+ if (script_table_get (table, G_UNICODE_SCRIPT_LATIN) +
+ script_table_get (table, G_UNICODE_SCRIPT_HAN) +
+ script_table_get (table, G_UNICODE_SCRIPT_BOPOMOFO) == num) {
+ retval = TRUE;
+ goto out;
+ }
+
+ /* Korean scripts. */
+ if (script_table_get (table, G_UNICODE_SCRIPT_LATIN) +
+ script_table_get (table, G_UNICODE_SCRIPT_HAN) +
+ script_table_get (table, G_UNICODE_SCRIPT_HANGUL) == num) {
+ retval = TRUE;
+ goto out;
+ }
+
+ /* Japanese scripts. */
+ if (script_table_get (table, G_UNICODE_SCRIPT_LATIN) +
+ script_table_get (table, G_UNICODE_SCRIPT_HAN) +
+ script_table_get (table, G_UNICODE_SCRIPT_HIRAGANA) +
+ script_table_get (table, G_UNICODE_SCRIPT_KATAKANA) == num) {
+ retval = TRUE;
+ goto out;
+ }
+
+ /* Ban mixes of more than two scripts. */
+ if (g_hash_table_size (table) > 2)
+ goto out;
+
+ /* Ban Latin + Cyrillic or Latin + Greek. */
+ if (script_table_get (table, G_UNICODE_SCRIPT_LATIN) > 0 &&
+ (script_table_get (table, G_UNICODE_SCRIPT_CYRILLIC) > 0 ||
+ script_table_get (table, G_UNICODE_SCRIPT_GREEK) > 0))
+ goto out;
+
+ /* Allow Latin + any other single script. */
+ retval = TRUE;
+
+out:
+ g_hash_table_unref (table);
+ g_free (unichars);
+
+ return retval;
+}
+
+static char *
+evaluate_host_for_display (const char *original_host,
+ const char *punycode_host)
+{
+ char **original_labels;
+ char **punycode_labels;
+ char *retval;
+
+ g_assert (original_host);
+ g_assert (punycode_host);
+
+ /* These arrays will have the same length. */
+ original_labels = g_strsplit (original_host, ".", -1);
+ punycode_labels = g_strsplit (punycode_host, ".", -1);
+
+ for (guint i = 0; i < g_strv_length (punycode_labels); i++) {
+ if (!validate_label_for_display (punycode_labels[i])) {
+ g_free (punycode_labels[i]);
+ punycode_labels[i] = g_strdup (original_labels[i]);
+ }
+ }
+
+ retval = g_strjoinv (".", punycode_labels);
+ g_strfreev (original_labels);
+ g_strfreev (punycode_labels);
+
+ return retval;
+}
+
+
/* Use this function to format a URI for display. The URIs used
* internally by WebKit may contain percent-encoded characters or
* punycode, which we do not want the user to see.
@@ -266,6 +410,7 @@ ephy_uri_decode (const char *uri_string)
static GMutex idna_creation_mutex;
SoupURI *uri;
char *percent_encoded_uri;
+ char *percent_decoded_host;
char *idna_decoded_name;
char *fully_decoded_uri;
UIDNAInfo info = UIDNA_INFO_INITIALIZER;
@@ -307,8 +452,10 @@ ephy_uri_decode (const char *uri_string)
return g_strdup (uri_string);
}
+ percent_decoded_host = soup_uri_decode (uri->host);
g_free (uri->host);
- uri->host = idna_decoded_name;
+ uri->host = evaluate_host_for_display (percent_decoded_host, idna_decoded_name);
+ g_free (percent_decoded_host);
}
/* Note: this also strips passwords from the display URI. */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]