[devhelp] Book: add FIXME comments
- From: Sébastien Wilmet <swilmet src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [devhelp] Book: add FIXME comments
- Date: Thu, 14 Dec 2017 20:55:38 +0000 (UTC)
commit 814aef03813aa723ed9be6a94a608a2f98748beb
Author: Sébastien Wilmet <swilmet gnome org>
Date: Thu Dec 14 21:49:04 2017 +0100
Book: add FIXME comments
src/dh-book.c | 12 +++++++++++-
1 files changed, 11 insertions(+), 1 deletions(-)
---
diff --git a/src/dh-book.c b/src/dh-book.c
index a12a62a..51779ba 100644
--- a/src/dh-book.c
+++ b/src/dh-book.c
@@ -43,8 +43,14 @@
#define EVENT_MERGE_TIMEOUT_SECS (2)
enum {
+ /* FIXME: a boolean property would be a better API instead of the
+ * ::enabled and ::disabled signals. Or this whole concept can be
+ * removed from DhBook, by introducing DhBookSelection, see:
+ * https://bugzilla.gnome.org/show_bug.cgi?id=784491#c3
+ */
SIGNAL_BOOK_ENABLED,
SIGNAL_BOOK_DISABLED,
+
SIGNAL_BOOK_UPDATED,
SIGNAL_BOOK_DELETED,
N_SIGNALS
@@ -402,7 +408,11 @@ dh_book_get_completions (DhBook *book)
DhLink *link = l->data;
gchar *str;
- /* Add additional "page:" and "book:" completions. */
+ /* Add additional "page:" and "book:" completions.
+ * FIXME: broken, doesn't match what DhKeywordModel
+ * does. But maybe the feature will be removed, see:
+ * https://bugzilla.gnome.org/show_bug.cgi?id=791442
+ */
if (dh_link_get_link_type (link) == DH_LINK_TYPE_BOOK) {
str = g_strdup_printf ("book:%s", dh_link_get_name (link));
priv->completions = g_list_prepend (priv->completions, str);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]