[gnome-continuous-yocto/gnomeostree-3.22-krogoth: 113/246] devtool: update-recipe: fix --initial-rev option

commit c3c25ac53da127bc481be6c07e3d5eb4f73bd22e
Author: Paul Eggleton <paul eggleton linux intel com>
Date:   Thu Jul 7 11:57:10 2016 +1200

    devtool: update-recipe: fix --initial-rev option
    In OE-Core revision 7baf57ad896112cf2258b3e2c2a1f8b756fb39bc I changed
    the default update-recipe behaviour to only update patches for commits
    that were changed; unfortunately I failed to handle the --initial-rev
    option which was broken after that point. Rework how the initial
    revision is passed in so that it now operates correctly.
    (From OE-Core rev: b2ca2523cc9e51a4759b4420b07b0b67b3f5ac43)
    (From OE-Core rev: d62aa298b80af78bc89f6e64736ce7383c3fa2de)
    Signed-off-by: Paul Eggleton <paul eggleton linux intel com>
    Signed-off-by: Ross Burton <ross burton intel com>
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>
    Signed-off-by: Armin Kuster <akuster808 gmail com>
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 scripts/lib/devtool/standard.py |   13 +++++--------
 1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
index 77a82d5..711399a 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -809,22 +809,19 @@ def modify(args, config, basepath, workspace):
     return 0
-def _get_patchset_revs(args, srctree, recipe_path):
+def _get_patchset_revs(srctree, recipe_path, initial_rev=None):
     """Get initial and update rev of a recipe. These are the start point of the
     whole patchset and start point for the patches to be re-generated/updated.
     import bb
-    if args.initial_rev:
-        return args.initial_rev, args.initial_rev
-    # Parse initial rev from recipe
+    # Parse initial rev from recipe if not specified
     commits = []
-    initial_rev = None
     with open(recipe_path, 'r') as f:
         for line in f:
             if line.startswith('# initial_rev:'):
-                initial_rev = line.split(':')[-1].strip()
+                if not initial_rev:
+                    initial_rev = line.split(':')[-1].strip()
             elif line.startswith('# commit:'):
@@ -1123,7 +1120,7 @@ def _update_recipe_patch(args, config, workspace, srctree, rd, config_data):
         raise DevtoolError('unable to find workspace bbappend for recipe %s' %
-    initial_rev, update_rev, changed_revs = _get_patchset_revs(args, srctree, append)
+    initial_rev, update_rev, changed_revs = _get_patchset_revs(srctree, append, args.initial_rev)
     if not initial_rev:
         raise DevtoolError('Unable to find initial revision - please specify '
                            'it with --initial-rev')

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]