[devhelp] Book: better setup file monitor



commit 2940d854449264efcbe487e6dd29c598d103d5f2
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Sun Dec 10 11:08:44 2017 +0100

    Book: better setup file monitor
    
    g_signal_connect_object() to have a safety belt.

 src/dh-book.c |   23 +++++++++++++++--------
 1 files changed, 15 insertions(+), 8 deletions(-)
---
diff --git a/src/dh-book.c b/src/dh-book.c
index ea08eff..c009e97 100644
--- a/src/dh-book.c
+++ b/src/dh-book.c
@@ -328,18 +328,25 @@ dh_book_new (GFile *index_file)
         g_free (language);
 
         /* Setup monitor for changes */
+
         priv->monitor = g_file_monitor_file (priv->index_file,
                                              G_FILE_MONITOR_NONE,
                                              NULL,
-                                             NULL);
+                                             &error);
+
+        if (error != NULL) {
+                g_warning ("Couldn't setup monitoring of changes in book '%s': %s",
+                           priv->id,
+                           error->message);
+                g_clear_error (&error);
+        }
+
         if (priv->monitor != NULL) {
-                g_signal_connect (priv->monitor,
-                                  "changed",
-                                  G_CALLBACK (book_monitor_event_cb),
-                                  book);
-        } else {
-                g_warning ("Couldn't setup monitoring of changes in book '%s'",
-                           priv->title);
+                g_signal_connect_object (priv->monitor,
+                                         "changed",
+                                         G_CALLBACK (book_monitor_event_cb),
+                                         book,
+                                         0);
         }
 
         return book;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]