[gnome-photos/gnome-3-26] spinner-box: Hide it when stopped even if it didn't animate



commit 7782021621c65faf7cd3f4a408305656fb518b9b
Author: Debarshi Ray <debarshir gnome org>
Date:   Fri Dec 8 18:46:10 2017 +0100

    spinner-box: Hide it when stopped even if it didn't animate
    
    There is no guarantee that the GtkRevealer will asynchronously animate
    before emitting notify::child-revealed. When it doesn't, the SpinnerBox
    remains visible, and obstructs the hyperlink in EmptyResultsBox from
    receiving the mouse event, or interferes with ToolCrop's GdkCursor.
    
    Fallout from 73e324730efcf047119ed530e1d0a7dc6a0102b7
    
    https://bugzilla.gnome.org/show_bug.cgi?id=785376

 src/photos-spinner-box.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/photos-spinner-box.c b/src/photos-spinner-box.c
index cfc8c13..162b193 100644
--- a/src/photos-spinner-box.c
+++ b/src/photos-spinner-box.c
@@ -104,8 +104,8 @@ photos_spinner_box_start (PhotosSpinnerBox *self)
 void
 photos_spinner_box_stop (PhotosSpinnerBox *self)
 {
-  gtk_revealer_set_reveal_child (GTK_REVEALER (self), FALSE);
   g_signal_connect (self, "notify::child-revealed", G_CALLBACK (photos_spinner_box_notify_child_revealed), 
NULL);
+  gtk_revealer_set_reveal_child (GTK_REVEALER (self), FALSE);
 
   gtk_spinner_stop (GTK_SPINNER (self->spinner));
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]