[gnome-control-center] network: Don't unref device after when parsing arguments



commit 5a3b19ef33e30e9d9bfd39309163862f89e85dab
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue Aug 29 05:16:30 2017 -0300

    network: Don't unref device after when parsing arguments
    
    When we add the NetDevice pointer to the GPtrArray, we have
    a single reference owned by the panel. When iterating over
    this GPtrArray, no reference is taken.
    
    The problem is that the code to handle command-line arguments
    was unreferencing the NetDevices when iterating over it,
    creating a disparity in the ref/unref pairs.
    
    Fix that by simply not unreferencing the NetDevice instance
    when iterating over it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786514

 panels/network/cc-network-panel.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/panels/network/cc-network-panel.c b/panels/network/cc-network-panel.c
index 665d552..c33cef1 100644
--- a/panels/network/cc-network-panel.c
+++ b/panels/network/cc-network-panel.c
@@ -376,8 +376,6 @@ handle_argv (CcNetworkPanel *panel)
                         g_object_unref (connection);
                 }
 
-                g_object_unref (object_tmp);
-
                 if (done)
                         return;
         }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]