[pitivi] project_: Make project.loading_assets a set()



commit b9c61b39215301b40b1bcb3d24d64a58e0db94d7
Author: Thibault Saunier <tsaunier gnome org>
Date:   Sat Jul 29 20:14:16 2017 -0400

    project_: Make project.loading_assets a set()
    
    Those have to be unique and could, in complex cases be
    duplicated.
    
    Reviewed-by: Alex Băluț <<alexandru balut gmail com>>
    Differential Revision: https://phabricator.freedesktop.org/D1818

 pitivi/project.py |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/pitivi/project.py b/pitivi/project.py
index 683e716..39ec5a7 100644
--- a/pitivi/project.py
+++ b/pitivi/project.py
@@ -667,7 +667,7 @@ class Project(Loggable, GES.Project):
         self.loaded = False
         self.at_least_one_asset_missing = False
         self.app = app
-        self.loading_assets = []
+        self.loading_assets = set()
         self.app.proxy_manager.connect("progress", self.__assetTranscodingProgressCb)
         self.app.proxy_manager.connect("error-preparing-asset",
                                        self.__proxyErrorCb)
@@ -1042,7 +1042,7 @@ class Project(Loggable, GES.Project):
 
         if progress == 100:
             self.info("No more loading assets")
-            self.loading_assets = []
+            self.loading_assets = set()
 
     def __assetTranscodingCancelledCb(self, unused_proxy_manager, asset):
         self.__setProxy(asset, None)
@@ -1089,12 +1089,12 @@ class Project(Loggable, GES.Project):
         asset.set_proxy(proxy)
         try:
             self.loading_assets.remove(asset)
-        except ValueError:
+        except KeyError:
             pass
 
         if proxy:
             self.add_asset(proxy)
-            self.loading_assets.append(proxy)
+            self.loading_assets.add(proxy)
 
         self.__updateAssetLoadingProgress()
 
@@ -1119,7 +1119,7 @@ class Project(Loggable, GES.Project):
             # Progress == 0 means "starting to import"
             self.emit("asset-loading-progress", 0, 0)
 
-        self.loading_assets.append(asset)
+        self.loading_assets.add(asset)
 
     def do_asset_removed(self, asset):
         self.app.proxy_manager.cancel_job(asset)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]