[gnome-builder] buffermanager: fix view creation calcuation



commit 37c37fe52bf3f212c64ff54ced0d561dd307bc5e
Author: Christian Hergert <chergert redhat com>
Date:   Tue Aug 8 17:39:20 2017 -0700

    buffermanager: fix view creation calcuation
    
    We always need to create a new view when is_new is TRUE. Background can
    only be serviced if we already have it open.

 libide/buffers/ide-buffer-manager.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/libide/buffers/ide-buffer-manager.c b/libide/buffers/ide-buffer-manager.c
index 69c9f4d..210a42d 100644
--- a/libide/buffers/ide-buffer-manager.c
+++ b/libide/buffers/ide-buffer-manager.c
@@ -647,7 +647,7 @@ ide_buffer_manager__load_file_query_info_cb (GObject      *object,
   LoadState *state;
   GError *error = NULL;
   gsize size = 0;
-  gboolean create_new_view;
+  gboolean create_new_view = FALSE;
 
   IDE_ENTRY;
 
@@ -715,7 +715,9 @@ ide_buffer_manager__load_file_query_info_cb (GObject      *object,
         }
     }
 
-  create_new_view = (state->flags & IDE_WORKBENCH_OPEN_FLAGS_BACKGROUND) ? FALSE : state->is_new;
+  if (state->is_new || (state->flags & IDE_WORKBENCH_OPEN_FLAGS_BACKGROUND) == 0)
+    create_new_view = TRUE;
+
   g_signal_emit (self, signals [LOAD_BUFFER], 0, state->buffer, create_new_view);
 
   gtk_source_file_loader_load_async (state->loader,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]