[epiphany/wip/sync: 68/74] password-manager: Username and password fields are not needed in _forget()
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/wip/sync: 68/74] password-manager: Username and password fields are not needed in _forget()
- Date: Sun, 6 Aug 2017 14:32:48 +0000 (UTC)
commit 433365421a24bd8fe7ce45311d26d0890717d8bc
Author: Gabriel Ivascu <ivascu gabriel59 gmail com>
Date: Tue Aug 1 03:26:13 2017 +0300
password-manager: Username and password fields are not needed in _forget()
lib/sync/ephy-password-manager.c | 9 +++------
lib/sync/ephy-password-manager.h | 4 +---
src/passwords-dialog.c | 4 +---
3 files changed, 5 insertions(+), 12 deletions(-)
---
diff --git a/lib/sync/ephy-password-manager.c b/lib/sync/ephy-password-manager.c
index ea48dbb..46f482e 100644
--- a/lib/sync/ephy-password-manager.c
+++ b/lib/sync/ephy-password-manager.c
@@ -699,20 +699,17 @@ forget_cb (GSList *records,
void
ephy_password_manager_forget (EphyPasswordManager *self,
const char *hostname,
- const char *username,
- const char *username_field,
- const char *password_field)
+ const char *username)
{
g_return_if_fail (EPHY_IS_PASSWORD_MANAGER (self));
g_return_if_fail (hostname);
- g_return_if_fail (password_field);
- g_return_if_fail (!username_field || username);
+ g_return_if_fail (username);
/* synchronizable-deleted signal needs an EphySynchronizable object,
* therefore we need to obtain the password record first and then emit
* the signal before clearing the password from the secret schema. */
ephy_password_manager_query (self, hostname, username,
- username_field, password_field,
+ NULL, NULL,
forget_cb, self);
}
diff --git a/lib/sync/ephy-password-manager.h b/lib/sync/ephy-password-manager.h
index 70c08cd..769fade 100644
--- a/lib/sync/ephy-password-manager.h
+++ b/lib/sync/ephy-password-manager.h
@@ -63,9 +63,7 @@ void ephy_password_manager_query (EphyPasswor
gpointer
user_data);
void ephy_password_manager_forget (EphyPasswordManager *self,
const char *hostname,
- const char *username,
- const char *username_field,
- const char *password_field);
+ const char *username);
void ephy_password_manager_forget_all (EphyPasswordManager *self);
/* Note: Below functions are deprecated and should not be used in newly written code.
* The only reason they still exist is that the profile migrator expects them. */
diff --git a/src/passwords-dialog.c b/src/passwords-dialog.c
index ad5fb73..7bcfaae 100644
--- a/src/passwords-dialog.c
+++ b/src/passwords-dialog.c
@@ -177,9 +177,7 @@ forget (GSimpleAction *action,
record = g_value_get_object (&val);
ephy_password_manager_forget (dialog->manager,
ephy_password_record_get_hostname (record),
- ephy_password_record_get_username (record),
- ephy_password_record_get_username_field (record),
- ephy_password_record_get_password_field (record));
+ ephy_password_record_get_username (record));
dialog->records = g_slist_remove (dialog->records, record);
g_object_unref (record);
g_value_unset (&val);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]