[gnome-commander] gnome-cmd-advrename-lexer.ll: fix for sequence-point



commit bc3e948d2d1c73b4924800ee345229ea4b10e2a4
Author: Mamoru TASAKA <mtasaka fedoraproject org>
Date:   Wed Apr 19 23:26:43 2017 +0900

    gnome-cmd-advrename-lexer.ll: fix for sequence-point
    
    src/gnome-cmd-advrename-lexer.ll:335:5: error: operation on 'n' may be undefined [-Werror=sequence-point]
      n = std::max(abs(start),abs(--n*step+start));
    
    Well, I really don't know the exact intention of this code.
    Just guess...

 src/gnome-cmd-advrename-lexer.ll |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/src/gnome-cmd-advrename-lexer.ll b/src/gnome-cmd-advrename-lexer.ll
index ffb45bd..37a3a65 100644
--- a/src/gnome-cmd-advrename-lexer.ll
+++ b/src/gnome-cmd-advrename-lexer.ll
@@ -331,7 +331,8 @@ tag_name    {ape}|{audio}|{doc}|{exif}|{file}|{flac}|{id3}|{image}|{iptc}|{pdf}|
 
 void gnome_cmd_advrename_reset_counter(int n, long start, int precision, int step)
 {
-  n = std::max(abs(start),abs(--n*step+start));
+  --n;
+  n = std::max(abs(start),abs(n*step+start));
 
   int auto_precision = n ? log10(n)+1 : 1;
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]