[gnome-continuous] bot: Notify in case of failure, not just success
- From: Emmanuele Bassi <ebassi src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-continuous] bot: Notify in case of failure, not just success
- Date: Tue, 25 Apr 2017 18:56:02 +0000 (UTC)
commit 994c0af36d3d1c81c9770ac4b33c4b64bebdc864
Author: Emmanuele Bassi <ebassi gnome org>
Date: Tue Apr 25 19:54:11 2017 +0100
bot: Notify in case of failure, not just success
If there's an IRC room specified in the manifest, we want to send a
message in case the build fails.
extras/ircbot/bot.py | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
---
diff --git a/extras/ircbot/bot.py b/extras/ircbot/bot.py
index 834854e..4a0662e 100644
--- a/extras/ircbot/bot.py
+++ b/extras/ircbot/bot.py
@@ -157,7 +157,7 @@ class BuildGnomeOrg(irc.IRCClient):
return msg
- def _get_channels_for_changed_components(self, taskname):
+ def _get_channels_for_changed_components(self, taskname, success):
current_task_path = os.path.join(self._workdir, 'results/tasks/%s/%s/' % (taskname, taskname))
build_path = os.path.join(current_task_path, 'build.json')
if not os.path.exists(build_path):
@@ -170,7 +170,10 @@ class BuildGnomeOrg(irc.IRCClient):
if 'built' not in build.keys():
return []
- component_names = [x['name'] for x in build['built'] if 'name' in x.keys()]
+ if success:
+ component_names = [x['name'] for x in build['built'] if 'name' in x.keys()]
+ else:
+ component_names = [x['name'] for x in build['failed'] if 'name' in x.keys()]
snapshot_path = os.path.join(current_task_path, 'snapshot.json')
if not os.path.exists(snapshot_path):
@@ -203,7 +206,7 @@ class BuildGnomeOrg(irc.IRCClient):
msg = self._status_line_for_task(taskname)
- affected_channels = self._get_channels_for_changed_components(taskname)
+ affected_channels = self._get_channels_for_changed_components(taskname, success)
if announce_always or success_changed:
self._sendTo(self._flood_channels, msg)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]