[gobject-introspection/gnome-3-24] Fix 'Bad file descriptor' error when checking libtool version



commit 59cfb35a2d4eecc1c4a8efb66da539a6314262b5
Author: Sam Thursfield <sam afuera me uk>
Date:   Fri Apr 14 13:02:35 2017 +0100

    Fix 'Bad file descriptor' error when checking libtool version
    
    Running g-ir-scanner on Fedora 25 (libtool 2.4.6) produces the following
    message on stderr, twice:
    
        /usr/bin/libtool: line 2460: printf: write error: Bad file descriptor
    
    This is because we were redirecting stdout to /dev/null incorrectly --
    we were opening /dev/null for reading rather than for writing.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=781312

 giscanner/utils.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/giscanner/utils.py b/giscanner/utils.py
index aff5393..da848d5 100644
--- a/giscanner/utils.py
+++ b/giscanner/utils.py
@@ -159,7 +159,7 @@ def get_libtool_command(options):
         libtool_cmd = 'glibtool'
     try:
         subprocess.check_call([libtool_cmd, '--version'],
-                              stdout=open(os.devnull))
+                              stdout=open('/dev/null', 'w'))
     except (subprocess.CalledProcessError, OSError):
         # If libtool's not installed, assume we don't need it
         return None


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]