[gnome-mud] connection-view: Don't read freed encoding



commit 507ddacf8ce344a7888dcb01da99ff95ff1b0673
Author: Steven Jackson <sj oscode net>
Date:   Sun Apr 23 14:46:35 2017 +0100

    connection-view: Don't read freed encoding
    
    Encoding was sometimes incorrectly freed, you can reproduce it by
    connecting to a MUD, which causes remote_encode to be set, then
    disconnecting and reconnecting. Valgrind will show the read.
    
    Reviewed-by: Mart Raudsepp <leio gentoo org>

 src/mud-connection-view.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/mud-connection-view.c b/src/mud-connection-view.c
index 66bbe72..0293d9b 100644
--- a/src/mud-connection-view.c
+++ b/src/mud-connection-view.c
@@ -1778,7 +1778,7 @@ mud_connection_view_add_text(MudConnectionView *view, gchar *message, enum MudCo
     remote = gconf_client_get_bool(client, key, NULL);
 
     if(view->remote_encode && remote)
-        encoding = view->remote_encoding;
+        encoding = g_strdup(view->remote_encoding);
     else
     {
         g_object_get(view->profile,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]