[bijiben] src: Fix old-style function definitions



commit c819c0c666e7a632f0dba8a3697deea56318600d
Author: Philip Withnall <philip withnall collabora co uk>
Date:   Wed Feb 24 21:17:21 2016 +0000

    src: Fix old-style function definitions
    
    func() means ‘a function called func which accepts an undefined set of
    parameters’; whereas func(void) means ‘a function called func which
    accepts zero parameters’. This allows optimised function calls (not
    really important here, but not bad to have), allows detection of bad
    behaviour (like passing parameters to these functions) and shuts up some
    compiler warnings.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762648

 src/bjb-import-dialog.c     |    4 ++--
 src/bjb-settings-dialog.c   |    4 ++--
 src/bjb-window-base.h       |    2 +-
 src/libbiji/biji-info-set.c |    2 +-
 src/libbiji/biji-info-set.h |    2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)
---
diff --git a/src/bjb-import-dialog.c b/src/bjb-import-dialog.c
index 388a970..68c3a60 100644
--- a/src/bjb-import-dialog.c
+++ b/src/bjb-import-dialog.c
@@ -85,7 +85,7 @@ G_DEFINE_TYPE (BjbImportDialog, bjb_import_dialog, GTK_TYPE_DIALOG)
 
 
 static ImportDialogChild *
-import_dialog_child_new ()
+import_dialog_child_new (void)
 {
   ImportDialogChild *retval = g_slice_new (ImportDialogChild);
 
@@ -154,7 +154,7 @@ application_quark (void)
 
 
 static GtkWidget *
-child_toggle_new ()
+child_toggle_new (void)
 {
   GtkWidget *w;
 
diff --git a/src/bjb-settings-dialog.c b/src/bjb-settings-dialog.c
index 8f7e95d..b3a9d6d 100644
--- a/src/bjb-settings-dialog.c
+++ b/src/bjb-settings-dialog.c
@@ -147,7 +147,7 @@ typedef struct
 
 
 static ProviderChild *
-provider_child_new ()
+provider_child_new (void)
 {
   ProviderChild *retval;
 
@@ -183,7 +183,7 @@ application_quark (void)
 
 
 static GtkWidget *
-child_toggle_new ()
+child_toggle_new (void)
 {
   GtkWidget *w;
 
diff --git a/src/bjb-window-base.h b/src/bjb-window-base.h
index b06eff3..7512ea1 100644
--- a/src/bjb-window-base.h
+++ b/src/bjb-window-base.h
@@ -76,7 +76,7 @@ gpointer               bjb_window_base_get_main_view (BjbWindowBase *self);
 BijiNoteObj           *bjb_window_base_get_note (BjbWindowBase *self);
 
 
-gboolean               switch_window_fullscreen();
+gboolean               switch_window_fullscreen (void);
 
 
 gboolean               bjb_window_base_get_show_search_bar (BjbWindowBase *self);
diff --git a/src/libbiji/biji-info-set.c b/src/libbiji/biji-info-set.c
index 71f2ef2..cc97e39 100644
--- a/src/libbiji/biji-info-set.c
+++ b/src/libbiji/biji-info-set.c
@@ -21,7 +21,7 @@
 
 
 BijiInfoSet *
-biji_info_set_new ()
+biji_info_set_new (void)
 {
   BijiInfoSet *retval;
 
diff --git a/src/libbiji/biji-info-set.h b/src/libbiji/biji-info-set.h
index f9023f5..e606420 100644
--- a/src/libbiji/biji-info-set.h
+++ b/src/libbiji/biji-info-set.h
@@ -57,7 +57,7 @@ typedef struct
 } BijiInfoSet;
 
 
-BijiInfoSet * biji_info_set_new ();
+BijiInfoSet * biji_info_set_new (void);
 
 void biji_info_set_free (BijiInfoSet *info);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]