[gnome-commander/ConvertWarningsToErrors] gnome-cmd-advrename-lexer.ll: fix format-nonliteral
- From: Uwe Scholz <uwescholz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-commander/ConvertWarningsToErrors] gnome-cmd-advrename-lexer.ll: fix format-nonliteral
- Date: Wed, 19 Apr 2017 20:07:51 +0000 (UTC)
commit a4bcef329f62a1ac1685a9332d0b2f326be4f91f
Author: Mamoru TASAKA <mtasaka fedoraproject org>
Date: Wed Apr 19 23:57:15 2017 +0900
gnome-cmd-advrename-lexer.ll: fix format-nonliteral
src/gnome-cmd-advrename-lexer.ll:542:99: error: format not a string literal, argument types not checked
[-Werror=format-nonliteral]
src/gnome-cmd-advrename-lexer.ll:557:151: error: format not a string literal, argument types not checked
[-Werror=format-nonliteral]
src/gnome-cmd-advrename-lexer.ll:585:85: error: format not a string literal, format string not checked
[-Werror=format-nonliteral]
Well, line numbers actually differs slightly, perhaps because ylwrap behaves a bit wrongly?
Actually erros comes from snprintf() and strftime().
This cannot be fixed because actuall format uses non-string-literal.
src/gnome-cmd-advrename-lexer.ll | 21 +++++++++++++++++++++
1 files changed, 21 insertions(+), 0 deletions(-)
---
diff --git a/src/gnome-cmd-advrename-lexer.ll b/src/gnome-cmd-advrename-lexer.ll
index 37a3a65..6a81f21 100644
--- a/src/gnome-cmd-advrename-lexer.ll
+++ b/src/gnome-cmd-advrename-lexer.ll
@@ -538,7 +538,14 @@ char *gnome_cmd_advrename_gen_fname (GnomeCmdFile *f, size_t new_fname_size)
{
static char counter_value[MAX_PRECISION+1];
+#if defined (__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wformat-nonliteral"
+#endif
snprintf (counter_value, MAX_PRECISION+1, (*i)->counter.fmt, (*i)->counter.n);
+#if defined (__GNUC__)
+#pragma GCC diagnostic pop
+#endif
fmt += counter_value;
(*i)->counter.n += (*i)->counter.step;
@@ -552,8 +559,15 @@ char *gnome_cmd_advrename_gen_fname (GnomeCmdFile *f, size_t new_fname_size)
static char random_value[MAX_XRANDOM_PRECISION+1];
sprintf (custom_counter_fmt, "%%0%u%c", (*i)->random.x_prec, (*i)->type==XRANDOM ? 'x'
: 'X');
+#if defined (__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wformat-nonliteral"
+#endif
snprintf (random_value, MAX_XRANDOM_PRECISION+1, custom_counter_fmt,
(*i)->random.x_prec<MAX_XRANDOM_PRECISION ? g_random_int_range (0,1 << 4*(*i)->random.x_prec)
: g_random_int ());
+#if defined (__GNUC__)
+#pragma GCC diagnostic pop
+#endif
fmt += random_value;
}
break;
@@ -581,8 +595,15 @@ char *gnome_cmd_advrename_gen_fname (GnomeCmdFile *f, size_t new_fname_size)
gboolean new_fname_has_percent = convert ((char *) fmt.c_str(), '%', ESC);
convert ((char *) fmt.c_str(), SUB, '%');
+#if defined (__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wformat-nonliteral"
+#endif
if (!strftime(new_fname, new_fname_size+1, fmt.c_str(), localtime(&f->info->mtime))) // if new_fname
is not big enough...
new_fname[new_fname_size] = '\0'; // ...
truncate
+#if defined (__GNUC__)
+#pragma GCC diagnostic pop
+#endif
if (new_fname_has_percent)
convert (new_fname, ESC, '%');
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]