[gjs/wip/ptomato/mozjs45: 2/27] boxed: Undefined value for field property
- From: Philip Chimento <pchimento src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gjs/wip/ptomato/mozjs45: 2/27] boxed: Undefined value for field property
- Date: Tue, 18 Apr 2017 04:42:40 +0000 (UTC)
commit 6d0522cefe3a4f32a2c64ca22a4c29568ca3a377
Author: Philip Chimento <philip chimento gmail com>
Date: Wed Mar 22 17:37:56 2017 +0000
boxed: Undefined value for field property
For boxed instances, the fields are implemented as properties with a
getter and setter. In SpiderMonkey 45, those properties are required to
have a value of undefined, rather than the (arbitrarily chosen) value of
null that we previously had.
https://bugzilla.gnome.org/show_bug.cgi?id=781429
gi/boxed.cpp | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gi/boxed.cpp b/gi/boxed.cpp
index 34d3ac8..466127f 100644
--- a/gi/boxed.cpp
+++ b/gi/boxed.cpp
@@ -888,7 +888,7 @@ define_boxed_class_fields(JSContext *cx,
if (!setter)
return false;
- if (!JS_DefineProperty(cx, proto, field_name, JS::NullHandleValue,
+ if (!JS_DefineProperty(cx, proto, field_name, JS::UndefinedHandleValue,
JSPROP_PERMANENT | JSPROP_SHARED | JSPROP_GETTER | JSPROP_SETTER,
JS_DATA_TO_FUNC_PTR(JSNative, getter.get()),
JS_DATA_TO_FUNC_PTR(JSNative, setter.get())))
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]