[gjs] tweener: Explicitly check if obj.time and obj.delay are defined



commit 3e63b3452e18e027a02c70301b379aaa70619ed2
Author: Debarshi Ray <debarshir gnome org>
Date:   Wed Apr 12 16:11:37 2017 +0200

    tweener: Explicitly check if obj.time and obj.delay are defined
    
    The delay property is often not specified which leads to this with
    SpiderMoney 38:
    JS WARNING: [resource:///org/gnome/gjs/modules/tweener/tweener.js 514]:
      reference to undefined property obj.delay
    
    Let's do the same for 'time' to be on the safe side.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=781219

 modules/tweener/tweener.js |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/modules/tweener/tweener.js b/modules/tweener/tweener.js
index 9535048..83bc870 100644
--- a/modules/tweener/tweener.js
+++ b/modules/tweener/tweener.js
@@ -510,8 +510,8 @@ function _addTweenOrCaller(target, tweeningParameters, isCaller) {
     if (!_engineExists) _startEngine();
 
     // Creates a "safer", more strict tweening object
-    var time = isNaN(obj.time) ? 0 : obj.time;
-    var delay = isNaN(obj.delay) ? 0 : obj.delay;
+    var time = obj.time || 0;
+    var delay = obj.delay || 0;
 
     var transition;
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]