[metacity/gnome-3-18] frames: use correct variable in for loop assignment
- From: Alberts Muktupāvels <muktupavels src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [metacity/gnome-3-18] frames: use correct variable in for loop assignment
- Date: Tue, 4 Apr 2017 18:19:51 +0000 (UTC)
commit bbe29f4bbfa553ad3e82bb710d33a29dcd667f34
Author: Shantanu Goel <sgoel01 yahoo com>
Date: Sat Mar 18 21:10:45 2017 -0400
frames: use correct variable in for loop assignment
update_context_styles is using the wrong variable when advancing
to the next key in the hash table which can cause an infinite
loop if # of variants is ever greater than 1.
This problem was originally reported here:
https://github.com/linuxmint/Cinnamon/issues/5254
The following patch was commited in Mint:
https://github.com/linuxmint/muffin/commit/6120bdde
This patch is just a shorter version of the Mint patch
and they deserve all the credit for the idea.
https://bugzilla.gnome.org/show_bug.cgi?id=780254
src/ui/frames.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/ui/frames.c b/src/ui/frames.c
index 497e885..e7e7420 100644
--- a/src/ui/frames.c
+++ b/src/ui/frames.c
@@ -205,7 +205,7 @@ update_style_contexts (MetaFrames *frames)
frames->normal_style = meta_theme_create_style_info (screen, NULL);
variants = g_hash_table_get_keys (frames->style_variants);
- for (variant = variants; variant; variant = variants->next)
+ for (variant = variants; variant; variant = variant->next)
{
style_info = meta_theme_create_style_info (screen, (char *)variant->data);
g_hash_table_insert (frames->style_variants,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]