[gnome-documents] documents: Prepare for future exceptions



commit aba41cecda0e85656e19f14d3ea6333f7dd76c0e
Author: Debarshi Ray <debarshir gnome org>
Date:   Fri Mar 31 20:09:17 2017 +0200

    documents: Prepare for future exceptions
    
    A subsequent commit, will add error handling to
    gd_queue_thumbnail_job_for_file_async. Let's be prepared for that.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=780779

 src/documents.js |   22 ++++++++++++++++++++--
 1 files changed, 20 insertions(+), 2 deletions(-)
---
diff --git a/src/documents.js b/src/documents.js
index 1cb66a7..b436b08 100644
--- a/src/documents.js
+++ b/src/documents.js
@@ -767,7 +767,16 @@ const LocalDocument = new Lang.Class({
     createThumbnail: function(callback) {
         GdPrivate.queue_thumbnail_job_for_file_async(this._file, Lang.bind(this,
             function(object, res) {
-                let thumbnailed = GdPrivate.queue_thumbnail_job_for_file_finish(res);
+                let thumbnailed = false;
+
+                try {
+                    thumbnailed = GdPrivate.queue_thumbnail_job_for_file_finish(res);
+                } catch (e) {
+                    /* We don't care about reporting errors here, just fail the
+                     * thumbnail.
+                     */
+                }
+
                 callback(thumbnailed);
             }));
     },
@@ -1017,7 +1026,16 @@ const OwncloudDocument = new Lang.Class({
     createThumbnail: function(callback) {
         GdPrivate.queue_thumbnail_job_for_file_async(this._file, Lang.bind(this,
             function(object, res) {
-                let thumbnailed = GdPrivate.queue_thumbnail_job_for_file_finish(res);
+                let thumbnailed = false;
+
+                try {
+                    thumbnailed = GdPrivate.queue_thumbnail_job_for_file_finish(res);
+                } catch (e) {
+                    /* We don't care about reporting errors here, just fail the
+                     * thumbnail.
+                     */
+                }
+
                 callback(thumbnailed);
             }));
     },


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]